-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop: add non-transactional delete #9878
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @Oreoxmt |
Co-authored-by: ekexium <eke@fastmail.com>
https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time |
IMO we don't have to explain as much details as crdb, though they can be found in the original doc. @Icemap Could you help put a summary here so that users know its advantage and how-tos at their first glance? |
Co-authored-by: Aolin <aolinz@outlook.com>
This is the Developer Guide, which corresponds to this section of CockroachDB: https://www.cockroachlabs.com/docs/stable/delete-data.html . By contrast, I think we've added a lot of examples. @ekexium @cfzjywxk |
/status LGT1 |
@Oreoxmt Please consider merging this, the Chinese version is already merged (pingcap/docs-cn#10814) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 59da794
|
In response to a cherrypick label: new pull request created: #11548. |
In response to a cherrypick label: new pull request created: #11549. |
In response to a cherrypick label: new pull request created: #11550. |
In response to a cherrypick label: new pull request created: #11551. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?