Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop: add non-transactional delete #9878

Merged
merged 9 commits into from
Dec 7, 2022

Conversation

Icemap
Copy link
Member

@Icemap Icemap commented Aug 8, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Icemap Icemap added translation/no-need No need to translate this PR. area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Aug 8, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 August 8, 2022 10:42
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2022
@Icemap
Copy link
Member Author

Icemap commented Aug 8, 2022

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot requested a review from Oreoxmt August 8, 2022 10:44
@TomShawn TomShawn requested a review from ekexium August 8, 2022 10:59
@cfzjywxk
Copy link
Contributor

https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time
@Icemap @ekexium
We could enhance this document more about the performance impact like query latency and space.Also more examples about the bulk-delete.

@ekexium
Copy link
Member

ekexium commented Aug 29, 2022

https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time @Icemap @ekexium We could enhance this document more about the performance impact like query latency and space.Also more examples about the bulk-delete.

IMO we don't have to explain as much details as crdb, though they can be found in the original doc. @Icemap Could you help put a summary here so that users know its advantage and how-tos at their first glance?

Co-authored-by: Aolin <aolinz@outlook.com>
@Icemap
Copy link
Member Author

Icemap commented Sep 5, 2022

https://www.cockroachlabs.com/docs/stable/delete.html#preserving-delete-performance-over-time @Icemap @ekexium We could enhance this document more about the performance impact like query latency and space.Also more examples about the bulk-delete.

This is the Developer Guide, which corresponds to this section of CockroachDB: https://www.cockroachlabs.com/docs/stable/delete-data.html . By contrast, I think we've added a lot of examples. @ekexium @cfzjywxk

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/no-need No need to translate this PR. labels Sep 5, 2022
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Sep 5, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2022
@Oreoxmt Oreoxmt self-requested a review September 5, 2022 08:14
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2022
@SunRunAway
Copy link
Contributor

SunRunAway commented Dec 7, 2022

@Oreoxmt Please consider merging this, the Chinese version is already merged (pingcap/docs-cn#10814)

Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2022
@Oreoxmt Oreoxmt removed the request for review from shichun-0415 December 7, 2022 06:46
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 59da794

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2022
@ti-chi-bot ti-chi-bot merged commit 5332934 into pingcap:master Dec 7, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 7, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11548.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11549.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 7, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11550.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 7, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11551.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/develop This PR relates to the area of TiDB App development. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants