Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidbcloud: update changefeed replication #8837

Open
wants to merge 1 commit into
base: release-5.4
Choose a base branch
from

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 8, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

refine the docs of the changefeed replication in tidb cloud

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 June 8, 2022 08:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2022
@qiancai qiancai added area/tidb-cloud This PR relates to the area of TiDB Cloud. translation/no-need No need to translate this PR. labels Jun 8, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 8, 2022
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. missing-translation-status This PR does not have translation status info. and removed missing-translation-status This PR does not have translation status info. labels Jun 8, 2022
@shichun-0415 shichun-0415 requested review from qiancai and removed request for shichun-0415 June 24, 2022 01:41
@qiancai qiancai added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jul 1, 2022
* You cannot use a secondary cluster as a source of **TiDB Cloud Replication** to another cluster.
* **TiDB Cloud Replication** contradicts [**Sink to Apache Kafka**](/tidb-cloud/changefeed-sink-to-apache-kafka.md) and [**Sink to MySQL**](/tidb-cloud/changefeed-sink-to-mysql.md). When **TiDB Cloud Replication** is enabled, neither the primary nor the secondary cluster can use the **Sink to Apache Kafka** or **Sink to MySQL** changefeed and vice versa.
* Because TiDB Cloud uses TiCDC to establish replication, it has the same [restrictions as TiCDC](https://docs.pingcap.com/tidb/stable/ticdc-overview#restrictions).
* The network latency between the primary and secondary clusters affects the performance or stability of **TiDB Cloud Replication**. with the following limitations:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The network latency between the primary and secondary clusters affects the performance or stability of **TiDB Cloud Replication**. with the following limitations:
* Depending on the network latency between the primary and secondary clusters, the performance and stability of **TiDB Cloud Replication** are affected as follows:

* Because TiDB Cloud uses TiCDC to establish replication, it has the same [restrictions as TiCDC](https://docs.pingcap.com/tidb/stable/ticdc-overview#restrictions).
* The network latency between the primary and secondary clusters affects the performance or stability of **TiDB Cloud Replication**. with the following limitations:
* The network latency less than 120 millisecond is recommended.
* When the network latency between 120 millisecond and 180 millisecond, the performance of **TiDB Cloud Replication** may be affected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* When the network latency between 120 millisecond and 180 millisecond, the performance of **TiDB Cloud Replication** may be affected.
* When the network latency is between 120 milliseconds and 180 milliseconds, the performance of **TiDB Cloud Replication** might be affected.

* **TiDB Cloud Replication** contradicts [**Sink to Apache Kafka**](/tidb-cloud/changefeed-sink-to-apache-kafka.md) and [**Sink to MySQL**](/tidb-cloud/changefeed-sink-to-mysql.md). When **TiDB Cloud Replication** is enabled, neither the primary nor the secondary cluster can use the **Sink to Apache Kafka** or **Sink to MySQL** changefeed and vice versa.
* Because TiDB Cloud uses TiCDC to establish replication, it has the same [restrictions as TiCDC](https://docs.pingcap.com/tidb/stable/ticdc-overview#restrictions).
* The network latency between the primary and secondary clusters affects the performance or stability of **TiDB Cloud Replication**. with the following limitations:
* The network latency less than 120 millisecond is recommended.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The network latency less than 120 millisecond is recommended.
* To achieve the best performance and stability of **TiDB Cloud Replication**, the network latency within 120 milliseconds is recommended.

* The network latency between the primary and secondary clusters affects the performance or stability of **TiDB Cloud Replication**. with the following limitations:
* The network latency less than 120 millisecond is recommended.
* When the network latency between 120 millisecond and 180 millisecond, the performance of **TiDB Cloud Replication** may be affected.
* When the network latenct is greater than 180 millisecond, **TiDB Cloud Replication** will not work.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* When the network latenct is greater than 180 millisecond, **TiDB Cloud Replication** will not work.
* When the network latency exceeds 180 milliseconds, **TiDB Cloud Replication** cannot provide service normally.

@@ -8,5 +8,6 @@ TiDB Cloud provides the following changefeeds to help you stream data from TiDB

- [Sink to Apache Kafka](/tidb-cloud/changefeed-sink-to-apache-kafka.md)
- [Sink to MySQL](/tidb-cloud/changefeed-sink-to-mysql.md)
- [Secondary Replication](changefeed-replication.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Secondary Replication](changefeed-replication.md)
- [Secondary Replication](/tidb-cloud/changefeed-replication.md)

@qiancai
Copy link
Collaborator

qiancai commented Jul 20, 2022

@leoppro I've completed the review and made some comments. PTAL. Thanks.

@qiancai qiancai added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 12, 2023
@qiancai qiancai added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jul 27, 2023
@qiancai qiancai added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 4, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


leoppro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qiancai qiancai added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tidb-cloud This PR relates to the area of TiDB Cloud. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants