Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM: add dm 5.4.0 performance test report #7466

Merged
merged 5 commits into from
Jan 26, 2022
Merged

DM: add dm 5.4.0 performance test report #7466

merged 5 commits into from
Jan 26, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

DM: add dm 5.4.0 performance test report

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn January 24, 2022 09:22
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2022
@shichun-0415 shichun-0415 added area/dm translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4. and removed missing-translation-status This PR does not have translation status info. labels Jan 24, 2022
@shichun-0415 shichun-0415 requested a review from GMHDBJD January 24, 2022 09:23
TomShawn
TomShawn reviewed Jan 25, 2022
View reviewed changes
@shichun-0415 @TomShawn
Apply suggestions from code review
f99d07a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Jan 25, 2022
View reviewed changes
dm/dm-benchmark 5.4.0.md Outdated

# DM 5.4.0 Benchmark Report

The performance of TiDB Data Migration (DM) v5.4.0 is nearly the same as that of TiDB DM v5.3.0. Therefore, you can refer to [DM 5.3.0 Benchmark Report](/dm/dm-benchmark-v5.3.0.md) to learn about the test purpose, environment, scenarios, and results of DM v5.3.0.
Copy link
Contributor

@TomShawn TomShawn Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The performance of TiDB Data Migration (DM) v5.4.0 is nearly the same as that of TiDB DM v5.3.0. Therefore, you can refer to [DM 5.3.0 Benchmark Report](/dm/dm-benchmark-v5.3.0.md) to learn about the test purpose, environment, scenarios, and results of DM v5.3.0.
The benchmark data of TiDB Data Migration (DM) v5.4.0 is nearly the same as that of DM v5.3.0. To learn the test purpose, environment, scenarios, and results of DM v5.3.0, refer to [DM 5.3.0 Benchmark Report](/dm/dm-benchmark-v5.3.0.md).

TomShawn
TomShawn reviewed Jan 25, 2022
View reviewed changes
dm/dm-benchmark 5.4.0.md Outdated
@@ -0,0 +1,8 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay attention to the file name. It should be dm-benchmark-v5.4.0.md.

@TomShawn
Copy link
Contributor

@shichun-0415 Please fix the CI error.

GMHDBJD
GMHDBJD approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022
TomShawn
TomShawn approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 173c3ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@ti-chi-bot ti-chi-bot merged commit 79171cc into pingcap:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
area/dm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichun-0415 @ti-chi-bot @TomShawn @GMHDBJD