Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ctc doc #5914

Merged
merged 4 commits into from
Jul 8, 2021
Merged

fix ctc doc #5914

merged 4 commits into from
Jul 8, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

update ctc doc in 3 files.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 2, 2021 08:41
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/label needs-cherry-pick-release-5.1
/translation from-docs-cn
/label v5.1

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.1 v5.1 This PR/issue applies to TiDB v5.1. and removed missing-translation-status This PR does not have translation status info. labels Jul 2, 2021
TomShawn
TomShawn reviewed Jul 6, 2021
View reviewed changes
sql-statements/sql-statement-alter-table.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-table.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-change-column.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-change-column.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-modify-column.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-change-column.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 6, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from TomShawn July 7, 2021 09:51
@TomShawn
Copy link
Contributor

TomShawn commented Jul 7, 2021

/rebase

Liuxiaozhen12 and others added 3 commits July 7, 2021 14:33
@TomShawn
fix ctc doc
0027b0a
@Liuxiaozhen12 @TomShawn
Apply suggestions from code review
a579146 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Liuxiaozhen12 @TomShawn
Update sql-statements/sql-statement-change-column.md
f88712a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 7, 2021
@TomShawn TomShawn requested a review from AilinKid July 8, 2021 02:15
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
AilinKid
AilinKid approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@AilinKid: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AilinKid
Copy link
Contributor

AilinKid commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@AilinKid: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9922540

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit 25bb0df into pingcap:master Jul 8, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5953.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
fix ctc doc (#5914) (#5953)
98989b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @TomShawn @ti-chi-bot @AilinKid