Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the release note for TiDB v5.1 #5840

Merged
merged 15 commits into from
Jun 24, 2021
Merged

Add the release note for TiDB v5.1 #5840

merged 15 commits into from
Jun 24, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jun 24, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Add the release note for v5.1

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 24, 2021 04:31
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2021
@qiancai qiancai added needs-cherry-pick-release-5.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 24, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 24, 2021
@TomShawn TomShawn added the v5.1 This PR/issue applies to TiDB v5.1. label Jun 24, 2021
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
qiancai and others added 3 commits June 24, 2021 13:15
@qiancai
Update release-5.1.0.md
7c201c0
@qiancai
Update release-5.1.0.md
335d043
@qiancai @TomShawn
Update releases/release-5.1.0.md
079eb1b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
releases/release-5.1.0.md Outdated Show resolved Hide resolved
releases/release-5.1.0.md Outdated Show resolved Hide resolved
releases/release-5.1.0.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@NingLin-P: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@tabokie: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

glorv
glorv reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilyjazz
lilyjazz reviewed Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
lilyjazz
lilyjazz approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@lilyjazz lilyjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a little bit more

@ti-chi-bot
Copy link
Member

@lilyjazz: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM, just a little bit more

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai @lilyjazz
Apply suggestions from code review
478cf6c 
Co-authored-by: FiatLux <fenhuilihe@gmail.com>
@ti-chi-bot
Copy link
Member

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

review for enforce-mpp:
need cherry-pick pingcap/docs-cn#6455 (review), others LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

qiancai
qiancai commented Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
qiancai
qiancai commented Jun 24, 2021
View reviewed changes
releases/release-5.1.0.md Outdated Show resolved Hide resolved
releases/release-5.1.0.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator Author

qiancai commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Member

@qiancai: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@TomShawn
Copy link
Contributor

/merge

@qiancai
Copy link
Collaborator Author

qiancai commented Jun 24, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot
Copy link
Member

@qiancai: These labels are not set on the issue: status/lgt1.

In response to this:

/remove-status LGT1
/status LGT2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d1707d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Jun 24, 2021

/merge

@TomShawn TomShawn merged commit fff8d90 into pingcap:master Jun 24, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5853.

ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
Add the release note for TiDB v5.1 (#5840) (#5853)
670fe11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv left review comments

@LittleFall LittleFall LittleFall approved these changes

@lilyjazz lilyjazz lilyjazz approved these changes

@tabokie tabokie tabokie approved these changes

@NingLin-P NingLin-P NingLin-P approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qiancai @ti-chi-bot @TomShawn @glorv @lilyjazz @tabokie @NingLin-P @LittleFall