Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oudated description in quick-start-with-tidb.md #5495

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Update oudated description in quick-start-with-tidb.md #5495

merged 1 commit into from
Apr 26, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 26, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Update outdated description in quick-start-with-tidb.md.
To close #5485.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2021
@TomShawn TomShawn changed the title Update quick-start-with-tidb.md Update oudated description in quick-start-with-tidb.md Apr 26, 2021
@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation doing
/assign Joyinqin
/cc @lilyjazz @King-Dylan

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 26, 2021
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 26, 2021
lilyjazz
lilyjazz reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@lilyjazz lilyjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@lilyjazz: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor Author

/cc @ran-huang

@ti-chi-bot ti-chi-bot requested a review from ran-huang April 26, 2021 08:14
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@TomShawn
Copy link
Contributor Author

/label require-LGT1
/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 /lgtm.

In response to this:

/label require-LGT1
/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 26, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7cea1de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot merged commit fa35df8 into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5495 to release-4.0
8dcbeb6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5506

@TomShawn TomShawn deleted the patch-1 branch April 26, 2021 08:20
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5495 to release-5.0
6aefa4c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5507

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
Update oudated description in quick-start-with-tidb.md (#5495) (#5506)
3d14f2a
ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
Update oudated description in quick-start-with-tidb.md (#5495) (#5507)
d7ca092
@Joyinqin Joyinqin mentioned this pull request Apr 27, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 27, 2021
This was referenced Apr 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyjazz lilyjazz lilyjazz left review comments

@King-Dylan King-Dylan Awaiting requested review from King-Dylan

@ran-huang ran-huang Awaiting requested review from ran-huang

Assignees

@Joyinqin Joyinqin

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated description in quick start guide
6 participants
@TomShawn @ti-chi-bot @ran-huang @ti-srebot @Joyinqin @lilyjazz