Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add 3 docs cluster-rename/cluster-restart/dm-import #5323

Merged
merged 3 commits into from
Apr 16, 2021
Merged

tiup: add 3 docs cluster-rename/cluster-restart/dm-import #5323

merged 3 commits into from
Apr 16, 2021

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add documents for commands cluster rename, cluster restart, and dm import.

Add 3 docs:

  • tiup/tiup-component-cluster-rename.md
  • tiup/tiup-component-cluster-restart.md
  • tiup/tiup-component-dm-import.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2021
@CharLotteiu
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2021
@CharLotteiu
Copy link
Contributor Author

Waiting for #5282 to be merged to fix dead links.

@CharLotteiu
Copy link
Contributor Author

/sig tiup
/sig doc
/cc @lucklove @qiancai

@ti-chi-bot ti-chi-bot requested a review from lucklove April 14, 2021 06:13
@ti-chi-bot
Copy link
Member

@CharLotteiu: The label(s) sig/doc cannot be applied, because the repository doesn't have them.

In response to this:

/sig tiup
/sig doc
/cc @lucklove @qiancai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot requested a review from qiancai April 14, 2021 06:13
@ti-chi-bot ti-chi-bot added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Apr 14, 2021
@CharLotteiu
Copy link
Contributor Author

/sig docs

@ti-chi-bot ti-chi-bot added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 14, 2021
qiancai
qiancai reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-cluster-restart.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-restart.md Outdated Show resolved Hide resolved
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@CharLotteiu
Copy link
Contributor Author

/rebase

@qiancai
Copy link
Collaborator

qiancai commented Apr 16, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharLotteiu
Copy link
Contributor Author

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 16, 2021
@CharLotteiu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c304667

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 9135a1f into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5323 to release-4.0
3be826a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5359

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5323 to release-5.0
d4e2157 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5360

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: add 3 docs cluster-rename/cluster-restart/dm-import (#5323) (#5359
13b1806 
)
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: add 3 docs cluster-rename/cluster-restart/dm-import (#5323) (#5360
711f350 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharLotteiu @ti-chi-bot @lucklove @qiancai @ti-srebot