Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct wrong description for a coprocessor config #4467

Merged
merged 3 commits into from
Dec 31, 2020
Merged

Correct wrong description for a coprocessor config #4467

merged 3 commits into from
Dec 31, 2020

Conversation

niezefeng
Copy link
Contributor

The description is wrong.
Change the larger than to less than.

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@niezefeng
Update tidb-configuration-file.md
1e40b50 
The description is wrong.
Change the larger than to less than.
@TomShawn TomShawn changed the title Update tidb-configuration-file.md Correct wrong description for a coprocessor config Dec 22, 2020
@TomShawn TomShawn requested a review from breezewish December 22, 2020 03:01
@TomShawn TomShawn added needs-cherry-pick-master Should cherry pick this PR to master branch. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Dec 22, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2020
@ti-srebot
Copy link
Contributor

@breeswish, PTAL.

@Joyinqin Joyinqin mentioned this pull request Dec 24, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Dec 24, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Dec 24, 2020
@ti-srebot
Copy link
Contributor

@breeswish, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@breeswish, PTAL.

@ti-srebot
Copy link
Contributor

@breeswish, PTAL.

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 31, 2020
@TomShawn TomShawn merged commit 1c15922 into pingcap:release-4.0 Dec 31, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 31, 2020
@niezefeng @ti-srebot
cherry pick pingcap#4467 to release-5.0
3ab8102 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 31, 2020
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4563

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 31, 2020
@niezefeng @ti-srebot
cherry pick pingcap#4467 to master
fcd0651 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 31, 2020
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #4564

TomShawn pushed a commit that referenced this pull request Dec 31, 2020
@ti-srebot @niezefeng
cherry pick #4467 to release-5.0 (#4563)
b1d479b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Zefeng.Nie <37355882+niezefeng@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Dec 31, 2020
@ti-srebot @niezefeng
cherry pick #4467 to master (#4564)
a4b26b0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Zefeng.Nie <37355882+niezefeng@users.noreply.github.com>
This was referenced Dec 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@TomShawn TomShawn TomShawn approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@Joyinqin Joyinqin

Labels
needs-cherry-pick-master Should cherry pick this PR to master branch. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niezefeng @ti-srebot @Joyinqin @breezewish @TomShawn