Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the tidb configuration documents. #4056

Merged
merged 6 commits into from
Oct 28, 2020
Merged

update the tidb configuration documents. #4056

merged 6 commits into from
Oct 28, 2020

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Oct 14, 2020

What is changed, added or deleted? (Required)

update the tidb configuration documents. Related: pingcap/tidb#19732.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 14, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn requested a review from kolbe October 15, 2020 03:27
@TomShawn TomShawn self-assigned this Oct 15, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Oct 15, 2020
TomShawn
TomShawn reviewed Oct 15, 2020
View reviewed changes
command-line-flags-for-tidb-configuration.md Outdated Show resolved Hide resolved
command-line-flags-for-tidb-configuration.md Outdated Show resolved Hide resolved
command-line-flags-for-tidb-configuration.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@TomShawn, @kolbe, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@TomShawn, @kolbe, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @kolbe, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @kolbe, PTAL.

@TomShawn TomShawn requested a review from tangenta October 28, 2020 05:20
tangenta
tangenta reviewed Oct 28, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2020
TomShawn
TomShawn approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2020
@TomShawn TomShawn merged commit a565357 into pingcap:master Oct 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Oct 28, 2020
@tangwz @ti-srebot
cherry pick pingcap#4056 to release-4.0
4ab5b3c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 28, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4103

TomShawn pushed a commit that referenced this pull request Oct 28, 2020
@ti-srebot @tangwz
cherry pick #4056 to release-4.0 (#4103)
3d68981 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: tangwz <tangwz.com@gmail.com>
@TomShawn TomShawn mentioned this pull request Nov 5, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 5, 2020
@ti-srebot ti-srebot mentioned this pull request Nov 5, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

@kolbe kolbe Awaiting requested review from kolbe

Assignees

@TomShawn TomShawn

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangwz @CLAassistant @ti-srebot @tangenta @TomShawn