-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stmt-reference, sysvars: Document dml-batch-size #3838
Conversation
It looks like this was removed in #1806 , but it needs to be added back because of the upgrade issue mentioned here :( |
lgtm |
LGTM |
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
- Scope: SESSION | ||
- Default value: 0 | ||
- Example value: 20000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nullnotnil Could you explain what example value
is? I find it confusing when reviewing the translation of this PR. From the context, 20000
does not appear in this document but in sql-statement-load-data.md
. Did you mean the example
in sql-statement-load-data.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked 20000
as an example value because this is the prior batch size for LOAD DATA
before it was changed to not be batched in master.
I think it is potentially useful for other sysvars, because the min/max values may be a very wide range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say In earlier releases of TiDB, the default batch size for LOAD DATA was 20000
? Here the example
seems a little confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove it. I don't think people will know to look up this value when they get an error, they will look up the reference for LOAD DATA
, which mentions the previous default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in #3977.
What is changed, added or deleted? (Required)
Part of #3155
Only relevant to master.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?