Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: make example in RBAC doc easier to understand #3709

Merged
merged 8 commits into from
Aug 26, 2020
Merged

sql: make example in RBAC doc easier to understand #3709

merged 8 commits into from
Aug 26, 2020

Conversation

ireneontheway
Copy link
Contributor

@ireneontheway ireneontheway commented Aug 24, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

To close #2496
make example easier to understand.
user can try RBAC by simply copy and paste sql in doc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/medium Changes of a medium size. needs-cherry-pick-3.0 status/PTAL This PR is ready for reviewing. labels Aug 24, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Aug 24, 2020 •
edited
Loading

@ireneontheway Looks like pingcap/docs-cn#2570 is a bit old. It is recommended to update the document according to the latest upstream version. Otherwise, outdated content might be aligned.

TomShawn
TomShawn reviewed Aug 24, 2020
View reviewed changes
@ireneontheway @TomShawn
Apply suggestions from code review
5192acc 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
imtbkcat
imtbkcat approved these changes Aug 26, 2020
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@imtbkcat,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 26, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e891739 into pingcap:master Aug 26, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 26, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3709 to release-3.0
dba0bfe 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3732

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 26, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3709 to release-3.1
dd51246 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3733

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 26, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#3709 to release-4.0
7b6b9ee 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3734

TomShawn pushed a commit that referenced this pull request Aug 26, 2020
@ti-srebot @ireneontheway
cherry pick #3709 to release-3.0 (#3732)
792247e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Aug 26, 2020
@ti-srebot @ireneontheway
cherry pick #3709 to release-3.1 (#3733)
257489e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Aug 26, 2020
@ti-srebot @ireneontheway
cherry pick #3709 to release-4.0 (#3734)
a19681a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
@ireneontheway ireneontheway deleted the improve-RBAC branch August 27, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtbkcat imtbkcat imtbkcat approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RBAC 文档描述不易操作，缺少场景说明
4 participants
@ireneontheway @TomShawn @ti-srebot @imtbkcat