Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toc: update the file order of br #3681

Merged
merged 2 commits into from
Aug 18, 2020
Merged

toc: update the file order of br #3681

merged 2 commits into from
Aug 18, 2020

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Aug 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

The current file order of BR in TOC is not logical.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ran-huang ran-huang added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-4.0 labels Aug 17, 2020
@ran-huang ran-huang requested a review from lilin90 August 17, 2020 06:32
@ran-huang ran-huang self-assigned this Aug 17, 2020
@ran-huang ran-huang mentioned this pull request Aug 17, 2020
Merged
9 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Aug 17, 2020
lilin90
lilin90 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2020
@lilin90 lilin90 added the size/small Changes of a small size. label Aug 18, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 18, 2020
Merged
9 tasks
@lilin90 lilin90 added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 18, 2020
@lilin90 lilin90 merged commit c394809 into master Aug 18, 2020
@lilin90 lilin90 deleted the update-br-toc branch August 18, 2020 03:04
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 18, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3681 to release-4.0
5445daf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 18, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3689

ti-srebot added a commit that referenced this pull request Aug 18, 2020
@ti-srebot
toc: update the file order of br (#3681) (#3689)
a5bb7a9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees

@ran-huang ran-huang

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-srebot @lilin90