Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add document of tispark support in tiup cluster #3611

Merged
merged 6 commits into from
Aug 27, 2020
Merged

tiup: add document of tispark support in tiup cluster #3611

merged 6 commits into from
Aug 27, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Aug 11, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Add documentations of (experimental) support of TiSpark in TiUP Cluster.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Aug 11, 2020
@ti-srebot
Copy link
Contributor

@AstroProfundis, @yikeke, PTAL.

yikeke
yikeke reviewed Aug 14, 2020
View reviewed changes
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tiup/tiup-cluster.md Outdated Show resolved Hide resolved
@TomShawn @yikeke
Apply suggestions from code review
7d5247e 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@TomShawn TomShawn requested a review from yikeke August 14, 2020 07:17
yikeke
yikeke approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
@ti-srebot
Copy link
Contributor

@yikeke, @AstroProfundis, PTAL.

@yikeke yikeke added require-LGT1 Indicates that the PR requires an LGTM. and removed require-LGT1 Indicates that the PR requires an LGTM. labels Aug 18, 2020
@ti-srebot
Copy link
Contributor

@yikeke, @AstroProfundis, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@yikeke, @AstroProfundis, PTAL.

@lilin90 lilin90 added the size/large Changes of a large size. label Aug 27, 2020
lilin90
lilin90 reviewed Aug 27, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2020
lilin90
lilin90 reviewed Aug 27, 2020
View reviewed changes
tispark-deployment-topology.md Outdated Show resolved Hide resolved
tispark-deployment-topology.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Aug 27, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 2dd251c into pingcap:master Aug 27, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 27, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3611 to release-4.0
9456120 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3748

lilin90 pushed a commit that referenced this pull request Aug 27, 2020
@ti-srebot @TomShawn
cherry pick #3611 to release-4.0 (#3748)
0d0507d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the tispork-tiop-add branch August 27, 2020 07:19
@lilin90 lilin90 mentioned this pull request Aug 27, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@yikeke yikeke yikeke approved these changes

@AstroProfundis AstroProfundis Awaiting requested review from AstroProfundis

Assignees
No one assigned
Labels
size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-srebot @lilin90 @yikeke