Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark-tidb-using-tpcc.md #3173

Merged
merged 9 commits into from
Jul 7, 2020
Merged

Update benchmark-tidb-using-tpcc.md #3173

merged 9 commits into from
Jul 7, 2020

Conversation

ireneontheway
Copy link
Contributor

@ireneontheway ireneontheway commented Jul 6, 2020

What is changed, added or deleted? (Required)

Update benchmark-tidb-using-tpcc.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2020

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn requested review from SE-Bin and TomShawn July 6, 2020 14:44
@TomShawn TomShawn added needs-cherry-pick-3.1 special-week PR from Document Special Week. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 6, 2020
@yikeke yikeke requested review from yikeke and removed request for TomShawn July 7, 2020 01:56
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small edits as follows:

benchmark/benchmark-tidb-using-tpcc.md Outdated Show resolved Hide resolved
benchmark/benchmark-tidb-using-tpcc.md Outdated Show resolved Hide resolved
benchmark/benchmark-tidb-using-tpcc.md Outdated Show resolved Hide resolved
benchmark/benchmark-tidb-using-tpcc.md Outdated Show resolved Hide resolved
benchmark/benchmark-tidb-using-tpcc.md Outdated Show resolved Hide resolved
@yikeke yikeke added the status/require-change Needs the author to address comments. label Jul 7, 2020
ireneontheway and others added 5 commits July 7, 2020 18:40
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@yikeke,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 9124427 into pingcap:master Jul 7, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3188

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3189

ti-srebot added a commit that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants