change absolute path to relative path of docs repo files #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
added
translation/from-docs-cn
yikeke
reviewed
Jun 17, 2020
| @@ -12,7 +12,7 @@ In this test, Sysbench 1.0.14 and TiDB 3.0 Beta are used. It is recommended to u | |||
|
|
|||
| - [Hardware recommendations](/hardware-and-software-requirements.md) | |||
|
|
|||
| - The TiDB cluster is deployed according to the [TiDB Deployment Guide](https://pingcap.com/docs/v3.0/online-deployment-using-ansible/). Suppose there are 3 servers in total. It is recommended to deploy 1 TiDB instance, 1 PD instance and 1 TiKV instance on each server. As for disk space, supposing that there are 32 tables and 10M rows of data on each table, it is recommended that the disk space where TiKV's data directory resides is larger than 512 GB. | |||
| - The TiDB cluster is deployed according to the [TiDB Deployment Guide](/online-deployment-using-ansible.md). Suppose there are 3 servers in total. It is recommended to deploy 1 TiDB instance, 1 PD instance and 1 TiKV instance on each server. As for disk space, supposing that there are 32 tables and 10M rows of data on each table, it is recommended that the disk space where TiKV's data directory resides is larger than 512 GB. | |||
There was a problem hiding this comment.
No need to change this. It should be a v3.0 link.
yikeke
reviewed
Jun 17, 2020
technical-writing-project-ideas.md
Outdated
| @@ -53,5 +53,5 @@ TiDB 4.0 Documentation Improvement | |||
|
|
|||
| - The open-source project: <https://github.com/pingcap/tidb> | |||
| - Existing documentation: <https://pingcap.com/docs> | |||
| - [How-to guides and tutorials](https://pingcap.com/docs/v4.0/how-to/deploy/orchestrated/tiup/): topics about how to deploy, configure, scale, or monitor a TiDB cluster in different ways | |||
| - [How-to guides and tutorials](/production-deployment-using-tiup.md): topics about how to deploy, configure, scale, or monitor a TiDB cluster in different ways | |||
There was a problem hiding this comment.
We can keep this absolute link because this document might migrate to somewhere outside of docs repo.
yikeke
reviewed
Jun 17, 2020
tidb-binlog/upgrade-tidb-binlog.md
Outdated
| @@ -48,7 +48,7 @@ Second, upgrade the Drainer component: | |||
|
|
|||
| ## Upgrade TiDB Binlog from Kafka/Local version to the cluster version | |||
|
|
|||
| The new TiDB versions (v2.0.8-binlog, v2.1.0-rc.5 or later) are not compatible with the [Kafka version](https://pingcap.com/docs/v2.1/reference/tidb-binlog/tidb-binlog-kafka/) or [Local version](https://pingcap.com/docs-cn/v2.1/reference/tidb-binlog/tidb-binlog-local/) of TiDB Binlog. If TiDB is upgraded to one of the new versions, it is required to use the cluster version of TiDB Binlog. If the Kafka or local version of TiDB Binlog is used before upgrading, you need to upgrade your TiDB Binlog to the cluster version. | |||
| The new TiDB versions (v2.0.8-binlog, v2.1.0-rc.5 or later) are not compatible with the Kafka version or [Local version](https://pingcap.com/docs-cn/v2.1/reference/tidb-binlog/tidb-binlog-local/) of TiDB Binlog. If TiDB is upgraded to one of the new versions, it is required to use the cluster version of TiDB Binlog. If the Kafka or local version of TiDB Binlog is used before upgrading, you need to upgrade your TiDB Binlog to the cluster version. | |||
There was a problem hiding this comment.
Suggested change
| The new TiDB versions (v2.0.8-binlog, v2.1.0-rc.5 or later) are not compatible with the Kafka version or [Local version](https://pingcap.com/docs-cn/v2.1/reference/tidb-binlog/tidb-binlog-local/) of TiDB Binlog. If TiDB is upgraded to one of the new versions, it is required to use the cluster version of TiDB Binlog. If the Kafka or local version of TiDB Binlog is used before upgrading, you need to upgrade your TiDB Binlog to the cluster version. | |
| The new TiDB versions (v2.0.8-binlog, v2.1.0-rc.5 or later) are not compatible with the Kafka version or Local version of TiDB Binlog. If TiDB is upgraded to one of the new versions, it is required to use the cluster version of TiDB Binlog. If the Kafka or local version of TiDB Binlog is used before upgrading, you need to upgrade your TiDB Binlog to the cluster version. |
It might confuse users if we give a zh link in an en doc.
|
Rest LGTM |
|
@yikeke PTAL again, thanks! |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jun 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
|
cherry pick to release-4.0 in PR #2925 |
TomShawn
added a commit
that referenced
this pull request
Jun 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
change absolute path to relative path of docs repo files.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?