Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add a faq about generated column #19369

Merged
merged 5 commits into from
Jan 22, 2025
Merged

ticdc: add a faq about generated column #19369

merged 5 commits into from
Jan 22, 2025

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Nov 11, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2024
@wk989898 wk989898 mentioned this pull request Nov 11, 2024
Merged
17 tasks
flowbehappy
flowbehappy reviewed Nov 11, 2024
View reviewed changes
ticdc/ticdc-faq.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Nov 11, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/doing This PR's assignee is translating this PR. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 22, 2025
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. and removed translation/doing This PR's assignee is translating this PR. labels Jan 22, 2025
qiancai
qiancai approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ticdc/ticdc-faq.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-22 06:18:22.580105183 +0000 UTC m=+248029.911024583: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2025
@wk989898 @qiancai
Update ticdc/ticdc-faq.md
2d5deef 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

@qiancai: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2025
@ti-chi-bot ti-chi-bot bot merged commit bd0d1c5 into pingcap:master Jan 22, 2025
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #20104.

This was referenced Jan 22, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #20105.

This was referenced Jan 22, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20106.

This was referenced Jan 22, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20107.

This was referenced Jan 22, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20108.

This was referenced Jan 22, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20109.

This was referenced Jan 22, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20110.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20107)
cb4dcee
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20110)
3699fa6
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20109)
b778be1
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20104)
5696bc8
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20106)
bbeb10e
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20105)
d3fd586
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2025
@ti-chi-bot
ticdc: add a faq about generated column (#19369) (#20108)
f3ac2f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

@qiancai qiancai

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wk989898 @qiancai @ti-chi-bot @flowbehappy