Update docs for deprecate-integer-display-length=true #19159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/work-in-progress
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
qiancai
added
for-release
ti-chi-bot
bot
removed
the
missing-translation-status
16 tasks
ti-chi-bot
bot
added
size/S
16 tasks
qiancai
reviewed
Nov 18, 2024
Co-authored-by: Grace Cai <qqzczy@126.com>
Oreoxmt
approved these changes
Nov 19, 2024
ti-chi-bot
bot
added
size/M
qiancai
approved these changes
Nov 25, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
CbcWestwolf
approved these changes
Nov 25, 2024
|
@CbcWestwolf: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
added
translation/done
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update the docs to follow the change in default value for
deprecate-integer-display-length.This follows the behavior in MySQL.
Integer types can be defined like
int(10)orint(8)orint. People often misunderstand the meaning of the number that is specified here (e.g. the 10 and the 8 here). This does not change the capacity of the value that can be stored it only changes how it might be displayed.See also https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html and pingcap/tidb#56529
Important: This changes the documentation for the variable and updates the page describing numeric types. However this does NOT update the output that might have changed.
Output that changes based on this variable:
SHOW CREATE TABLEDESCRIBE <table>,EXPLAIN <table>andSHOW COLUMNS FROM ...EXPLAIN...Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Don't merge before this PR has been merged
pingcap/tidb#56529
Do your changes match any of the following descriptions?