Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: re-enable links must start with slash check #1847

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Feb 24, 2020

What is changed, added or deleted?

re-enable links must start with slash check

What is the related PR or file link(s)?

  • Reference link(s):
  • This PR is to align with:
  • N/A (not applicable)

Important Notice:

If your changes apply to multiple TiDB documentation versions, to trigger the bot to cherry-pick this PR to other release branches, make sure you add labels such as:

  • needs-cherry-pick-3.0
  • needs-cherry-pick-3.1
  • needs-cherry-pick-2.1

@@ -60,7 +60,7 @@ while read -r tasks; do
) &
done
wait
done <<<"$(find "." -type f -name '*.md' | xargs -n 10)"
done <<<"$(find "." -type f -not -path './node_modules/*' -name '*.md' | xargs -n 10)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore node_modules directory

@cofyc cofyc requested a review from yikeke February 24, 2020 02:38
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc cofyc force-pushed the links-must-start-with-slash branch from 058aa73 to e9933f8 Compare February 24, 2020 02:40
@cofyc cofyc force-pushed the links-must-start-with-slash branch from e9933f8 to 86364ea Compare February 24, 2020 02:56
@cofyc cofyc added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2020
@yikeke yikeke merged commit 5fcb683 into pingcap:master Feb 24, 2020
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants