Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos for .md files at root directory #17405

Merged
merged 2 commits into from
May 9, 2024

Conversation

n0vad3v
Copy link
Contributor

@n0vad3v n0vad3v commented Apr 30, 2024

What is changed, added or deleted? (Required)

Tons of typo fix for .md files at root directory of this repo.

Some backgrounds on how theses typos are fixed, I've wrote a (Chinese) blog about this: https://nova.moe/fast-typo-fix/ (English version: https://nova.moe/fast-typo-fix-en/) 😇

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

ti-chi-bot bot commented Apr 30, 2024

Welcome @n0vad3v!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 30, 2024
Copy link

ti-chi-bot bot commented Apr 30, 2024

Hi @n0vad3v. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
@n0vad3v
Copy link
Contributor Author

n0vad3v commented Apr 30, 2024

@ti-chi-bot

It looks like this is your first PR to pingcap/docs 🎉.

Nope, I've PR merged before: #2058, don't you remember? oh, that was the time you're not here.😏

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2024
@qiancai
Copy link
Collaborator

qiancai commented May 6, 2024

Hi @n0vad3v, thanks very much for your contribution. It seems that most typos in this PR have been fixed in https://github.com/pingcap/docs/pull/17381/files already (actually it was inspired by your brilliant blog https://nova.moe/fast-typo-fix/ 👍). Now, I've merged the latest upstream to this PR and there is one typo left in this PR.

@n0vad3v
Copy link
Contributor Author

n0vad3v commented May 6, 2024

@qiancai Wow, nice😇.

@qiancai qiancai requested a review from nolouch May 6, 2024 03:43
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label May 6, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 6, 2024
@qiancai qiancai self-assigned this May 6, 2024
Copy link

ti-chi-bot bot commented May 9, 2024

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 9, 2024
Copy link

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 06:51:36.432243444 +0000 UTC m=+1117650.189379002: ☑️ agreed by qiancai.

@qiancai qiancai added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 9, 2024
@qiancai
Copy link
Collaborator

qiancai commented May 9, 2024

/approve

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17450.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17451.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-8.1: error checking out release-8.1: exit status 1. output: error: pathspec 'release-8.1' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17452.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 9, 2024
@lilin90 lilin90 removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 9, 2024
dveeden pushed a commit to dveeden/docs that referenced this pull request May 15, 2024
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 17, 2024
@Oreoxmt Oreoxmt mentioned this pull request Jun 17, 2024
17 tasks
@lilin90 lilin90 mentioned this pull request Jun 18, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants