-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos for .md files at root directory #17405
Conversation
Welcome @n0vad3v! |
Hi @n0vad3v. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nope, I've PR merged before: #2058, don't you remember? oh, that was the time you're not here.😏 |
Hi @n0vad3v, thanks very much for your contribution. It seems that most typos in this PR have been fixed in https://github.com/pingcap/docs/pull/17381/files already (actually it was inspired by your brilliant blog https://nova.moe/fast-typo-fix/ 👍). Now, I've merged the latest upstream to this PR and there is one typo left in this PR. |
@qiancai Wow, nice😇. |
@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/approve |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: cannot checkout |
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
Tons of typo fix for .md files at root directory of this repo.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?