-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gcs:// instead of s3:// when the external storage is Google Cloud Storage #16893
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My main suggestion is to expand the GCS abbreviation so it is clear that it is referring to Google Cloud Storage.
@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -54,6 +54,10 @@ The following is an example of an Amazon S3 URI for [`IMPORT INTO`](/sql-stateme | |||
s3://external/test.csv?access-key=${access-key}&secret-access-key=${secret-access-key} | |||
``` | |||
|
|||
> **Note:** | |||
> | |||
> Please note that the XML API of Google Cloud Storage (GCS) is not fully compatible with the s3:// protocol. If you are using GCS, please use the gcs:// protocol instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Please note that the XML API of Google Cloud Storage (GCS) is not fully compatible with the s3:// protocol. If you are using GCS, please use the gcs:// protocol instead. | |
> Please note that the XML API of Google Cloud Storage (GCS) is not fully compatible with the `s3://` protocol. If you are using GCS, please use the `gcs://` protocol instead. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
The DeleteObjects API is not supported in the GCS XML API. That will cause the "NotImplemented" error if the caller use "s3://" schema instead of "gcs://"
see pingcap/tidb#50918
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?