Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gcs:// instead of s3:// when the external storage is Google Cloud Storage #16893

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Mar 28, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

The DeleteObjects API is not supported in the GCS XML API. That will cause the "NotImplemented" error if the caller use "s3://" schema instead of "gcs://"
see pingcap/tidb#50918

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign toutdesuite for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2024
Copy link
Collaborator

@benmeadowcroft benmeadowcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My main suggestion is to expand the GCS abbreviation so it is clear that it is referring to Google Cloud Storage.

external-storage-uri.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2024
Copy link

ti-chi-bot bot commented Mar 29, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -54,6 +54,10 @@ The following is an example of an Amazon S3 URI for [`IMPORT INTO`](/sql-stateme
s3://external/test.csv?access-key=${access-key}&secret-access-key=${secret-access-key}
```

> **Note:**
>
> Please note that the XML API of Google Cloud Storage (GCS) is not fully compatible with the s3:// protocol. If you are using GCS, please use the gcs:// protocol instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Please note that the XML API of Google Cloud Storage (GCS) is not fully compatible with the s3:// protocol. If you are using GCS, please use the gcs:// protocol instead.
> Please note that the XML API of Google Cloud Storage (GCS) is not fully compatible with the `s3://` protocol. If you are using GCS, please use the `gcs://` protocol instead.

@Oreoxmt Oreoxmt self-assigned this Apr 2, 2024
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Apr 2, 2024
@Oreoxmt Oreoxmt added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Apr 2, 2024
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants