Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise plan replayer load #11976

Merged
merged 2 commits into from
Jan 11, 2023
Merged

revise plan replayer load #11976

merged 2 commits into from
Jan 11, 2023

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2023
@TomShawn TomShawn added needs-cherry-pick-release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. and removed missing-translation-status This PR does not have translation status info. labels Jan 10, 2023
@TomShawn TomShawn requested a review from shichun-0415 January 10, 2023 09:02
shichun-0415
shichun-0415 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

sql-plan-replayer.md Outdated Show resolved Hide resolved
sql-plan-replayer.md Outdated Show resolved Hide resolved
sql-plan-replayer.md Outdated Show resolved Hide resolved
@TomShawn @shichun-0415
Apply suggestions from code review
4cb5550 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 11, 2023
@TomShawn
Copy link
Contributor Author

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2023
@TomShawn
Copy link
Contributor Author

/merge

1 similar comment
@TomShawn
Copy link
Contributor Author

/merge

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@TomShawn
Copy link
Contributor Author

/merge

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@TomShawn
Copy link
Contributor Author

/merge

1 similar comment
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4cb5550

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2023
@ti-chi-bot ti-chi-bot merged commit c502cbd into pingcap:master Jan 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #12000.

@TomShawn TomShawn deleted the plan-rplayer-load branch January 11, 2023 06:57
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12001.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #12002.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #12004.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12006.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12008.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 11, 2023
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #12010.

ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12000)
b5d0f31
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12001)
dee056b
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12006)
584c4cb
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12004)
8d55fb4
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12010)
7b57333
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12008)
beba5fc
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
revise plan replayer load (#11976) (#12002)
15369f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @shichun-0415