Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"DDL algorithm assertions" is not clear #8615

Open
yahonda opened this issue May 13, 2022 · 5 comments
Open

"DDL algorithm assertions" is not clear #8615

yahonda opened this issue May 13, 2022 · 5 comments
Assignees
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. tracked This issue has been tracked.

Comments

@yahonda
Copy link
Member

yahonda commented May 13, 2022

File: /master/basic-features.md

In this page There is a link to https://docs.pingcap.com/tidb/dev/sql-statement-alter-table that says "DDL algorithm assertions" .
I am not clear what "DDL algorithm assertions" actually means.

@ran-huang
Copy link
Contributor

@morgo Can you take a look?
"DDL algorithm assertions" was first introduced in #6130

@morgo
Copy link
Contributor

morgo commented May 13, 2022

It's this syntax:

ALGORITHM=INPLACE, LOCK=NONE;

See: https://dev.mysql.com/doc/refman/5.7/en/innodb-online-ddl-operations.html

@ran-huang
Copy link
Contributor

@yahonda I hope this solved your problem. :)

It's this syntax:

ALGORITHM=INPLACE, LOCK=NONE;

See: https://dev.mysql.com/doc/refman/5.7/en/innodb-online-ddl-operations.html

@yahonda
Copy link
Member Author

yahonda commented May 16, 2022

Thanks for the answer. Still I do not get what "assertion" intends here.

I'm thinking about changing this document link name from
"Online DDL" or "ALTER TABLE"?

@ran-huang
Copy link
Contributor

Thanks for the answer. Still I do not get what "assertion" intends here.

I'm thinking about changing this document link name from "Online DDL" or "ALTER TABLE"?

@morgo What do you think?

@shichun-0415 shichun-0415 added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. tracked This issue has been tracked. labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. tracked This issue has been tracked.
Projects
None yet
Development

No branches or pull requests

4 participants