Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clinic v0.8.0: Support collection of SQL query plan related information #9884

Merged
merged 11 commits into from
Aug 30, 2022
Merged

clinic v0.8.0: Support collection of SQL query plan related information #9884

merged 11 commits into from
Aug 30, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jun 17, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Support collection of SQL query plan related information in Clinic v0.8.0

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/clinic This PR relates to the area of TiDB Clinic. labels Jun 17, 2022
@Oreoxmt Oreoxmt requested a review from qqqdan June 17, 2022 07:19
@Oreoxmt Oreoxmt self-assigned this Jun 17, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2022
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jun 17, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jun 17, 2022

/verify

@Oreoxmt Oreoxmt requested a review from TomShawn June 17, 2022 07:22
Oreoxmt
Oreoxmt commented Jun 17, 2022
View reviewed changes
clinic/clinic-collect-sql-query-plan.md Outdated
> - 暂时不支持采集 TiDB Operator 部署集群的数据。

- 导出排查现场 TiDB 集群的相关信息，导出为 ZIP 格式的文件用于保存。
- Diag 中采集的数据与 TiDB 中 `PLAN REPLAYER` 功能采集的数据有少量差距，具体见[采集输出结果](#采集输出结果)。
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qqqdan 采集输出信息部分并没有说明比 PLAN REPLAYER 少的采集数据是哪些

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不想对比差异。。就把我们采集到啥列一下吧，我改一下这一句

@qqqdan qqqdan requested a review from Yisaer June 23, 2022 06:25
Yisaer
Yisaer reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

clinic/clinic-collect-sql-query-plan.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2022
@Oreoxmt Oreoxmt force-pushed the clinic/collection-sql-query-plan branch from e7cff3c to 21a0346 Compare July 5, 2022 08:15
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. translation/doing This PR’s assignee is translating this PR. labels Jul 11, 2022
@Oreoxmt Oreoxmt mentioned this pull request Jul 11, 2022
Open
12 tasks
qqqdan
qqqdan approved these changes Jul 12, 2022
View reviewed changes
clinic/clinic-collect-sql-query-plan.md Outdated
> - 暂时不支持采集 TiDB Operator 部署集群的数据。

- 导出排查现场 TiDB 集群的相关信息，导出为 ZIP 格式的文件用于保存。
- Diag 中采集的数据与 TiDB 中 `PLAN REPLAYER` 功能采集的数据有少量差距，具体见[采集输出结果](#采集输出结果)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``suggestion

  • Diag 中采集的数据与 TiDB 中 PLAN REPLAYER 功能采集的数据有少量差距，Diag 采集的详细输出见采集输出结果。

clinic/clinic-collect-sql-query-plan.md Outdated
> - 暂时不支持采集 TiDB Operator 部署集群的数据。

- 导出排查现场 TiDB 集群的相关信息，导出为 ZIP 格式的文件用于保存。
- Diag 中采集的数据与 TiDB 中 `PLAN REPLAYER` 功能采集的数据有少量差距，具体见[采集输出结果](#采集输出结果)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不想对比差异。。就把我们采集到啥列一下吧，我改一下这一句

clinic/clinic-collect-sql-query-plan.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
TomShawn
TomShawn reviewed Jul 13, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
clinic/clinic-collect-sql-query-plan.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from TomShawn July 14, 2022 02:59
@Yisaer
Copy link
Contributor

Yisaer commented Aug 16, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
@Oreoxmt Oreoxmt requested a review from Yisaer August 30, 2022 04:11
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 30, 2022

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 30, 2022
@Oreoxmt Oreoxmt force-pushed the clinic/collection-sql-query-plan branch from a29ec77 to f9872d7 Compare August 30, 2022 06:25
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Aug 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f9872d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2022
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Aug 30, 2022
@ti-chi-bot ti-chi-bot merged commit a0e01d8 into pingcap:master Aug 30, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 30, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11131.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 30, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11132.

ti-chi-bot added a commit that referenced this pull request Aug 30, 2022
@ti-chi-bot
clinic v0.8.0: Support collection of SQL query plan related informati…
22b8a1f 
…on (#9884) (#11132)
ti-chi-bot added a commit that referenced this pull request Aug 30, 2022
@ti-chi-bot
clinic v0.8.0: Support collection of SQL query plan related informati…
68c519d 
…on (#9884) (#11131)
@Oreoxmt Oreoxmt deleted the clinic/collection-sql-query-plan branch February 14, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@qqqdan qqqdan qqqdan approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Oreoxmt Oreoxmt

Labels
area/clinic This PR relates to the area of TiDB Clinic. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oreoxmt @ti-chi-bot @Yisaer @qqqdan @TomShawn