Skip to content

add warnings for consistency check#9526

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
5kbpers:consistency-check
May 18, 2022
Merged

add warnings for consistency check#9526
ti-chi-bot merged 6 commits into
pingcap:masterfrom
5kbpers:consistency-check

Conversation

@5kbpers

@5kbpers 5kbpers commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: 5kbpers hustmh@gmail.com

What is changed, added or deleted? (Required)

Currently, consistency-check isn't compatible with TiDB GC (see tikv/tikv#12564), add warnings for related docs about configuration of consistency-check to prevent users enable it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 18, 2022 08:26
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2022
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread tikv-configuration-file.md
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread dynamic-config.md
@5kbpers
add reminder for consistency-check
78d8bd4 
Signed-off-by: 5kbpers <hustmh@gmail.com>
@5kbpers 5kbpers force-pushed the consistency-check branch from 1f893a6 to 78d8bd4 Compare May 18, 2022 09:04
@5kbpers
address comments
84c45f8 
Signed-off-by: 5kbpers <hustmh@gmail.com>
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread tikv-configuration-file.md
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread dynamic-config.md Outdated
@5kbpers 5kbpers changed the title remove consistency check from config docs add warnings for consistency check May 18, 2022
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread tikv-control.md Outdated
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread tikv-configuration-file.md Outdated
5kbpers and others added 3 commits May 18, 2022 17:11
@5kbpers
address comments
2030730 
Signed-off-by: 5kbpers <hustmh@gmail.com>
@5kbpers @TomShawn
Update dynamic-config.md
11d0d38 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@5kbpers @TomShawn
Update tikv-control.md
bfe29fd 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed May 18, 2022
View reviewed changes
Comment thread tikv-control.md Outdated
TomShawn
TomShawn approved these changes May 18, 2022
View reviewed changes

@TomShawn TomShawn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2022
@5kbpers @TomShawn
Update tikv-control.md
73c9122 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. and removed missing-translation-status This PR does not have translation status info. labels May 18, 2022
@TomShawn

TomShawn commented May 18, 2022

Copy link
Copy Markdown
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2022
@TomShawn

TomShawn commented May 18, 2022

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot commented May 18, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 73c9122

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2022
@ti-chi-bot ti-chi-bot merged commit 5ba363f into pingcap:master May 18, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented May 18, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #9527.

@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented May 18, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #9528.

ti-chi-bot added a commit that referenced this pull request May 19, 2022
@ti-chi-bot
add warnings for consistency check (#9526) (#9527)
001d909
ti-chi-bot added a commit that referenced this pull request May 19, 2022
@ti-chi-bot
add warnings for consistency check (#9526) (#9528)
5d57478
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 19, 2022
@Oreoxmt Oreoxmt mentioned this pull request May 19, 2022
Merged
14 tasks
This was referenced May 20, 2022
Merged
Merged
@5kbpers 5kbpers mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BornChanger BornChanger BornChanger approved these changes
+2 more reviewers
@hicqu hicqu hicqu approved these changes
@TomShawn TomShawn TomShawn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@5kbpers @ti-chi-bot @TomShawn @hicqu @BornChanger @Oreoxmt