Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in dev branch, app dev part. Update delete-data.md #9330

Closed
wants to merge 2 commits into from

Conversation

shawn0915
Copy link
Contributor

fix typo for table ratings and column rated_at.

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

fix typo for table `ratings` and column `rated_at`.
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 7, 2022 05:11
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2022
@TomShawn TomShawn requested review from winkyao, qiancai and Icemap May 7, 2022 05:32
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. area/develop This PR relates to the area of TiDB App development. and removed missing-translation-status This PR does not have translation status info. labels May 7, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2022
@TomShawn TomShawn removed their request for review May 9, 2022 02:09
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2022
@ti-chi-bot
Copy link
Member

@shawn0915: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai requested review from Oreoxmt and removed request for qiancai June 10, 2022 02:11
@Icemap
Copy link
Member

Icemap commented Jun 10, 2022

非常抱歉 @shawn0915 ,非常棒的 PR,但是它落后了当前分支太多,而且这部分的文档变更涉及到示例代码的变更,同时还需中英文文档同步。因此我会关闭它。
非常感谢您的贡献。祝好。

另附此 PR 的相关链接:

@Icemap Icemap closed this Jun 10, 2022
@shawn0915 shawn0915 deleted the patch-3 branch June 20, 2022 03:02
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants