Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM: update optimistic shard ddl #9317

Merged
merged 8 commits into from
May 25, 2022
Merged

DM: update optimistic shard ddl #9317

merged 8 commits into from
May 25, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented May 6, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label May 6, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 6, 2022 11:45
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2022
@GMHDBJD GMHDBJD requested review from lichunzhu and sunzhaoyang May 6, 2022 11:45
@CLAassistant
Copy link

CLAassistant commented May 6, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn requested review from ran-huang and removed request for TomShawn May 7, 2022 01:53
@TomShawn TomShawn added area/dm translation/doing This PR’s assignee is translating this PR. v6.1 This PR/issue applies to TiDB v6.1. and removed missing-translation-status This PR does not have translation status info. labels May 7, 2022
@ran-huang ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2022
ran-huang
ran-huang reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
GMHDBJD and others added 2 commits May 12, 2022 17:18
@GMHDBJD @ran-huang
Update dm/feature-shard-merge-optimistic.md
5169590 
Co-authored-by: Ran <huangran@pingcap.com>
@GMHDBJD @ran-huang
Update dm/feature-shard-merge-optimistic.md
96bb4c8 
Co-authored-by: Ran <huangran@pingcap.com>
sunzhaoyang
sunzhaoyang reviewed May 17, 2022
View reviewed changes
dm/feature-shard-merge-optimistic.md Outdated
@@ -32,18 +32,26 @@ DM 支持在线上执行分库分表的 DDL 语句（通称 Sharding DDL），
- 例如：在分表执行过 `ADD COLUMN A INT; DROP COLUMN A; ADD COLUMN A FLOAT;`，在其他分表直接执行 `ADD COLUMN A FLOAT` 即可，不需要三条 DDL 都执行一遍。
- 执行 DDL 时要注意观察 DM 迁移状态。当迁移报错时，需要判断这个批次的 DDL 是否会造成数据不一致。

“乐观协调”模式暂不支持以下语句：
“乐观协调”模式时，上游在执行**不兼容**的 DDL 时，需要**保证该 DDL 在各分表中按相同的顺序**执行。**不兼容**的 DDL 是指改变列名，列属性，或列默认值的 DDL。如：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”不兼容“ 这个词感觉可以换一下或者再解释一下。可能会有人看到不兼容以为是无法执行，但其实只是有限制条件而已。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一句解释吧：“不兼容指.....（DM 行为）“ @GMHDBJD

Copy link
Contributor Author

@GMHDBJD GMHDBJD May 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”不兼容“ 这个词感觉可以换一下或者再解释一下

有推荐吗 @sunzhaoyang

ran-huang
ran-huang reviewed May 25, 2022
View reviewed changes
dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
dm/feature-shard-merge-optimistic.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
sunzhaoyang
sunzhaoyang approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5e8f6e2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2022
@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@ti-chi-bot ti-chi-bot merged commit 440dbe1 into pingcap:master May 25, 2022
@ran-huang ran-huang mentioned this pull request May 30, 2022
Merged
13 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@sunzhaoyang sunzhaoyang sunzhaoyang approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees

@ran-huang ran-huang

Labels
area/dm first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GMHDBJD @ti-chi-bot @CLAassistant @ran-huang @sunzhaoyang @TomShawn