Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shardddl: add unlock ddl lock doc for optimistic mode #8714

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Mar 21, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

DM optimistic mode has support shard-ddl-lock in v6.0. This PR will update the related documents.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2022
@lichunzhu lichunzhu requested a review from GMHDBJD March 21, 2022 12:11
@lichunzhu
Copy link
Contributor Author

@GMHDBJD @TomShawn PTAL

@TomShawn
Copy link
Contributor

@GMHDBJD @TomShawn PTAL

Is there an FD JIRA for this? I think this is expected to be tracked in JIRA and triaged by Cira and QA.

@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. area/dm translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 22, 2022
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@ran-huang ran-huang self-assigned this Apr 12, 2022
@ran-huang ran-huang requested review from ran-huang and removed request for TomShawn April 12, 2022 06:32
dm/manually-handling-sharding-ddl-locks.md Outdated Show resolved Hide resolved
dm/manually-handling-sharding-ddl-locks.md Outdated Show resolved Hide resolved
用于主动请求 DM-master 解除指定的 DDL lock,包括的操作:请求 owner 执行 DDL 操作,请求其他非 owner 的 DM-worker 跳过 DDL 操作,移除 DM-master 上的 lock 信息。
用于主动请求 DM-master 解除指定的 DDL lock。

1. 悲观模式 `unlock` 包括操作:请求 owner 执行 DDL 操作,请求其他非 owner 的 DM-worker 跳过 DDL 操作,移除 DM-master 上的 lock 信息。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议用 <SimpleTab> 来分别显示悲观模式和乐观模式

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fix correct?298fff8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成了这样:3e398cf

官网会渲染为类似这样的效果:
image

dm/manually-handling-sharding-ddl-locks.md Outdated Show resolved Hide resolved
dm/manually-handling-sharding-ddl-locks.md Outdated Show resolved Hide resolved
dm/manually-handling-sharding-ddl-locks.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added needs-cherry-pick-release-6.0 type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Apr 28, 2022
lichunzhu and others added 3 commits May 5, 2022 20:59
Co-authored-by: Ran <huangran@pingcap.com>
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Contributor

/verify

Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
Copy link
Contributor

ran-huang commented Jun 15, 2022

@lichunzhu @GMHDBJD PTAL at this commit cc2a426. The rest of the PR LGTM.

@ran-huang ran-huang added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 15, 2022
@ran-huang ran-huang added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 29, 2022
@qiancai
Copy link
Collaborator

qiancai commented Jul 7, 2023

Removed the needs-cherry-pick-release-6.6 label because the v6.6 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.6 and will no longer receive new updates.

@qiancai
Copy link
Collaborator

qiancai commented Aug 25, 2023

Removed the needs-cherry-pick-release-7.0 label because the v7.0 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v7.0 and will no longer receive new updates.

@qiancai
Copy link
Collaborator

qiancai commented Oct 20, 2023

Removed the needs-cherry-pick-release-7.2 label because the v7.2 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v7.2 and will no longer receive new updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants