Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DM webui guide #8599

Merged
merged 18 commits into from
Mar 24, 2022
Merged

Add DM webui guide #8599

merged 18 commits into from
Mar 24, 2022

Conversation

sunzhaoyang
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 9, 2022 02:47
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2022
@sunzhaoyang
Copy link
Contributor Author

/cc @Ehco1996

@ti-chi-bot ti-chi-bot requested a review from Ehco1996 March 9, 2022 02:47
Ehco1996
Ehco1996 reviewed Mar 9, 2022
View reviewed changes
dm/deploy-a-dm-cluster-using-tiup-offline.md Outdated Show resolved Hide resolved
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
@TomShawn TomShawn self-assigned this Mar 9, 2022
@TomShawn TomShawn added area/dm translation/doing This PR’s assignee is translating this PR. v6.0 This PR/issue applies to TiDB v6.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 9, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2022
TomShawn
TomShawn reviewed Mar 14, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
Ehco1996
Ehco1996 reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restLGTM

dm/dm-webui-guide.md Outdated Show resolved Hide resolved
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
sunzhaoyang
sunzhaoyang commented Mar 16, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
sunzhaoyang
sunzhaoyang commented Mar 16, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 16, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated

Dashboard 是内嵌了 DM 的 Grafana Dashboard，包含两个视图`Standard`和`Professional`分别展示了不同角度的监控信息。

如果要在 DM WebUI 中正确显示 Dashboard，首次部署必须确认以下两个步骤正确完成：
Copy link
Contributor

@TomShawn TomShawn Mar 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

首次部署，是指通过 TiUP 部署 DM 吗？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是 grafana 的配置，应该是首次部署 grafana 时需要加入如下配置项

TomShawn
TomShawn reviewed Mar 16, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated

## 上游配置

创建迁移任务之前，需要先行创建所需要同步的上游数据源信息。请注意：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否先介绍下上游配置这个页面能帮助用户完成什么任务呢？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

填写上游信息啊，这个一般都能理解的

Ehco1996
Ehco1996 reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/dm-webui-guide.md Outdated Show resolved Hide resolved
dm/dm-webui-guide.md Outdated

Dashboard 是内嵌了 DM 的 Grafana Dashboard，包含两个视图`Standard`和`Professional`分别展示了不同角度的监控信息。

如果要在 DM WebUI 中正确显示 Dashboard，首次部署必须确认以下两个步骤正确完成：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是 grafana 的配置，应该是首次部署 grafana 时需要加入如下配置项

sunzhaoyang
sunzhaoyang commented Mar 16, 2022
View reviewed changes
dm/dm-webui-guide-v1.md Outdated Show resolved Hide resolved
@TomShawn @sunzhaoyang
Update dm/dm-webui-guide-v1.md
51b590e 
Co-authored-by: sunzy <sunzy2@gmail.com>
sunzhaoyang
sunzhaoyang commented Mar 16, 2022
View reviewed changes
Copy link
Contributor Author

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@TomShawn TomShawn added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2022
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 17, 2022
@TomShawn TomShawn mentioned this pull request Mar 17, 2022
Merged
15 tasks
TomShawn
TomShawn reviewed Mar 21, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 22, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 22, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 22, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
sunzhaoyang
sunzhaoyang commented Mar 23, 2022
View reviewed changes
dm/dm-webui-guide.md Outdated Show resolved Hide resolved
@sunzhaoyang @TomShawn
Apply suggestions from code review
86abf42 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86abf42

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@TomShawn TomShawn merged commit 45d2b2c into pingcap:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees

@TomShawn TomShawn

Labels
area/dm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunzhaoyang @ti-chi-bot @TomShawn @Ehco1996