Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-ngm-reload-for-dashboard #8542

Merged
merged 2 commits into from
Mar 2, 2022
Merged

update-ngm-reload-for-dashboard #8542

merged 2 commits into from
Mar 2, 2022

Conversation

qqqdan
Copy link
Contributor

@qqqdan qqqdan commented Mar 2, 2022 •
edited by shichun-0415
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qqqdan qqqdan requested a review from lilyjazz March 2, 2022 08:30
@ti-chi-bot ti-chi-bot requested a review from TomShawn March 2, 2022 08:30
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 2, 2022
@qqqdan qqqdan requested review from shichun-0415 and removed request for TomShawn March 2, 2022 08:30
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 2, 2022
@qqqdan qqqdan requested a review from nexustar March 2, 2022 08:31
@shichun-0415 shichun-0415 added sig/diagnosis translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 2, 2022
@shichun-0415 shichun-0415 self-assigned this Mar 2, 2022
@shichun-0415 shichun-0415 added the type/enhancement The issue or PR belongs to an enhancement. label Mar 2, 2022
@shichun-0415 shichun-0415 added type/bugfix This PR fixes a bug. and removed type/enhancement The issue or PR belongs to an enhancement. labels Mar 2, 2022
shichun-0415
shichun-0415 reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@qqqdan @shichun-0415
Apply suggestions from code review
e7c690f 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2022
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 2, 2022
@Mini256 Mini256 added area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. and removed are/diagnosis labels Mar 2, 2022
@shichun-0415 shichun-0415 added needs-cherry-pick-master Should cherry pick this PR to master branch. and removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 2, 2022
qiancai
qiancai approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 2, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e7c690f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@ti-chi-bot ti-chi-bot merged commit 726c6ac into pingcap:release-5.4 Mar 2, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 2, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8550.

ti-chi-bot added a commit that referenced this pull request Mar 2, 2022
@ti-chi-bot
update-ngm-reload-for-dashboard (#8542) (#8550)
2475954
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 3, 2022
@shichun-0415 shichun-0415 mentioned this pull request Mar 3, 2022
Merged
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 3, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyjazz lilyjazz lilyjazz approved these changes

@nexustar nexustar nexustar approved these changes

@qiancai qiancai qiancai approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. needs-cherry-pick-master Should cherry pick this PR to master branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qqqdan @ti-chi-bot @shichun-0415 @lilyjazz @nexustar @qiancai @Mini256 @TomShawn