improve csv separator notes #7504

sunzhaoyang · 2021-11-15T05:39:26Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-11-15T05:40:05Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Liuxiaozhen12
hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CLAassistant · 2021-11-15T05:40:09Z

All committers have signed the CLA.

hfxsd · 2021-11-16T02:57:31Z

dumpling-overview.md

@@ -370,7 +370,7 @@ SET GLOBAL tidb_gc_life_time = '10m';
 | --cert | 用于 TLS 连接的 client certificate 文件的地址 |
 | --key | 用于 TLS 连接的 client private key 文件的地址 |
 | --csv-delimiter | csv 文件中字符类型变量的定界符 | '"' |
-| --csv-separator | csv 文件中各值的分隔符 | ',' |
+| --csv-separator | csv 文件中各值的分隔符，不建议使用默认的“,”简单分隔符，推荐“|+|”等非常见字符组合| ','|


应该在产品侧进行改进。

hfxsd

LGTM

hfxsd · 2021-11-17T02:30:35Z

dumpling-overview.md

@@ -370,7 +370,7 @@ SET GLOBAL tidb_gc_life_time = '10m';
 | --cert | 用于 TLS 连接的 client certificate 文件的地址 |
 | --key | 用于 TLS 连接的 client private key 文件的地址 |
 | --csv-delimiter | csv 文件中字符类型变量的定界符 | '"' |
-| --csv-separator | csv 文件中各值的分隔符 | ',' |
+| --csv-separator | csv 文件中各值的分隔符，不建议使用默认的“,”简单分隔符，推荐“|+|”等非常见字符组合| ','|


hfxsd

LGTM

sunzhaoyang · 2021-11-18T07:17:54Z

/cc @lance6716 PTAL

ti-chi-bot · 2021-11-18T07:17:56Z

@sunzhaoyang: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lance6716 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tidb-lightning/migrate-from-csv-using-tidb-lightning.md

dumpling-overview.md

tidb-lightning/migrate-from-csv-using-tidb-lightning.md

Liuxiaozhen12 · 2021-11-19T13:00:21Z

/merge

ti-chi-bot · 2021-11-19T13:00:24Z

This pull request has been accepted and is ready to merge.

Commit hash: 0561778

ti-chi-bot · 2021-11-19T13:02:25Z

In response to a cherrypick label: new pull request created: #7563.

ti-chi-bot · 2021-11-19T13:03:02Z

In response to a cherrypick label: new pull request created: #7564.

ti-chi-bot · 2021-11-19T13:03:39Z

In response to a cherrypick label: new pull request created: #7565.

ti-chi-bot · 2021-11-19T13:04:16Z

In response to a cherrypick label: new pull request created: #7566.

* improve csv separator notes * apply suggest * Update dumpling-overview.md * Apply suggestions from code review Co-authored-by: sunzhaoyang <sunzy2@gmail.com>

improve csv separator notes

99a90cc

ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Nov 15, 2021

ti-chi-bot requested a review from TomShawn November 15, 2021 05:40

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2021

Liuxiaozhen12 requested a review from hfxsd November 15, 2021 08:33

Liuxiaozhen12 assigned hfxsd Nov 15, 2021

Liuxiaozhen12 added needs-cherry-pick-release-5.0 translation/doing This PR’s assignee is translating this PR. labels Nov 15, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 15, 2021

Liuxiaozhen12 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 15, 2021

TomShawn added the area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. label Nov 16, 2021

hfxsd reviewed Nov 16, 2021

View reviewed changes

hfxsd approved these changes Nov 16, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2021

hfxsd mentioned this pull request Nov 16, 2021

Improve csv separator notes pingcap/docs#6819

Merged

13 tasks

hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 16, 2021

hfxsd reviewed Nov 17, 2021

View reviewed changes

sunzhaoyang added 2 commits November 18, 2021 09:39

apply suggest

abf8f32

Update dumpling-overview.md

caf5c54

sunzhaoyang requested a review from hfxsd November 18, 2021 01:42

hfxsd approved these changes Nov 18, 2021

View reviewed changes

Liuxiaozhen12 approved these changes Nov 18, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2021

This was referenced Nov 18, 2021

Improve csv separator notes (#6819) pingcap/docs#6841

Merged

Improve csv separator notes (#6819) pingcap/docs#6842

Merged

Improve csv separator notes (#6819) pingcap/docs#6843

Merged

ti-chi-bot requested a review from lance6716 November 18, 2021 07:17

sunzhaoyang commented Nov 18, 2021

View reviewed changes

tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated Show resolved Hide resolved

sunzhaoyang commented Nov 18, 2021

View reviewed changes

dumpling-overview.md Outdated Show resolved Hide resolved

sunzhaoyang commented Nov 18, 2021

View reviewed changes

tidb-lightning/migrate-from-csv-using-tidb-lightning.md Outdated Show resolved Hide resolved

Apply suggestions from code review

0561778

Liuxiaozhen12 added the needs-cherry-pick-release-5.3 label Nov 19, 2021

lance6716 approved these changes Nov 19, 2021

View reviewed changes

sunzhaoyang requested a review from lance6716 November 19, 2021 12:55

lance6716 approved these changes Nov 19, 2021

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2021

ti-chi-bot merged commit 3d592f1 into pingcap:master Nov 19, 2021

ti-chi-bot mentioned this pull request Nov 19, 2021

improve csv separator notes (#7504) #7563

Merged

14 tasks

ti-chi-bot mentioned this pull request Nov 19, 2021

improve csv separator notes (#7504) #7564

Merged

14 tasks

ti-chi-bot mentioned this pull request Nov 19, 2021

improve csv separator notes (#7504) #7565

Merged

14 tasks

ti-chi-bot mentioned this pull request Nov 19, 2021

improve csv separator notes (#7504) #7566

Merged

14 tasks

TomShawn pushed a commit that referenced this pull request Nov 22, 2021

improve csv separator notes (#7504) (#7564)

01a7a87

* improve csv separator notes * apply suggest * Update dumpling-overview.md * Apply suggestions from code review Co-authored-by: sunzhaoyang <sunzy2@gmail.com>

TomShawn pushed a commit that referenced this pull request Nov 22, 2021

improve csv separator notes (#7504) (#7565)

fd5b849

* improve csv separator notes * apply suggest * Update dumpling-overview.md * Apply suggestions from code review Co-authored-by: sunzhaoyang <sunzy2@gmail.com>

TomShawn pushed a commit that referenced this pull request Nov 22, 2021

improve csv separator notes (#7504) (#7566)

12160a8

* improve csv separator notes * apply suggest * Update dumpling-overview.md * Apply suggestions from code review Co-authored-by: sunzhaoyang <sunzy2@gmail.com>

ti-chi-bot added a commit that referenced this pull request Nov 22, 2021

improve csv separator notes (#7504) (#7563)

b0c6d57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve csv separator notes #7504

improve csv separator notes #7504

sunzhaoyang commented Nov 15, 2021

ti-chi-bot commented Nov 15, 2021 •

edited

Loading

CLAassistant commented Nov 15, 2021 •

edited

Loading

hfxsd Nov 16, 2021

hfxsd left a comment

hfxsd Nov 17, 2021

hfxsd left a comment

sunzhaoyang commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

Liuxiaozhen12 commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

	\| --csv-separator \| csv 文件中各值的分隔符，不建议使用默认的“,”简单分隔符，推荐“\|+\|”等非常见字符组合\| ','\|
	\| --csv-separator \| csv 文件中各值的分隔符，不建议使用默认的“,”简单分隔符，推荐“\\|+\\|”等非常见字符组合\| ','\|

improve csv separator notes #7504

improve csv separator notes #7504

Conversation

sunzhaoyang commented Nov 15, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Nov 15, 2021 • edited Loading

CLAassistant commented Nov 15, 2021 • edited Loading

hfxsd Nov 16, 2021

Choose a reason for hiding this comment

hfxsd left a comment

Choose a reason for hiding this comment

hfxsd Nov 17, 2021

Choose a reason for hiding this comment

hfxsd left a comment

Choose a reason for hiding this comment

sunzhaoyang commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

Liuxiaozhen12 commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 19, 2021

ti-chi-bot commented Nov 15, 2021 •

edited

Loading

CLAassistant commented Nov 15, 2021 •

edited

Loading