fix expression index's document again. #6950

wjhuang2016 · 2021-08-25T08:38:09Z

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

ti-chi-bot · 2021-08-25T08:38:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

bb7133 · 2021-08-25T08:52:11Z

sql-statements/sql-statement-create-index.md

@@ -186,6 +186,14 @@ DROP INDEX idx1 ON t1;
 ```

 > **注意：**
+> 
+> 表达式索引涉及众多表达式，为了确保正确性，只有经过充分测试的函数才允许直接创建，这些函数可以查询变量 `tidb_allow_function_for_expression_index` 了解。对于未经过充分测试的函数，其存在正确性风险, 我们将其视为实验特性，不建议在生产环境中使用。如果仍然希望使用，可以在 [TiDB 配置文件](/tidb-configuration-file.md#allow-expression-index-从-v400-版本开始引入)中进行以下设置：


Suggested change

> 表达式索引涉及众多表达式，为了确保正确性，只有经过充分测试的函数才允许直接创建，这些函数可以查询变量 `tidb_allow_function_for_expression_index` 了解。对于未经过充分测试的函数，其存在正确性风险, 我们将其视为实验特性，不建议在生产环境中使用。如果仍然希望使用，可以在 [TiDB 配置文件](/tidb-configuration-file.md#allow-expression-index-从-v400-版本开始引入)中进行以下设置：

> 表达式索引涉及众多表达式，为了确保正确性，只有经过充分测试的函数才允许直接创建，这些函数可以通过查询变量 `tidb_allow_function_for_expression_index` 得到。对于未经过充分测试的函数，由于尚未完成充分的测试，我们将其视为实验特性，不建议在生产环境中使用。如果仍然希望使用，可以在 [TiDB 配置文件](/tidb-configuration-file.md#allow-expression-index-从-v400-版本开始引入)中进行以下设置：

这里直接把 GA 的函数列出来吧。

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

ti-chi-bot · 2021-08-25T11:46:18Z

@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

tidb-configuration-file.md

sql-statements/sql-statement-create-index.md

wjhuang2016 · 2021-08-26T03:38:45Z

system-variables.md

+### `tidb_allow_function_for_expression_index` <span class="version-mark">从 v5.2.0 版本开始引入</span>
+
+- 作用域：NONE
+- 这个变量用于显示创建表达式索引所允许使用的函数。


同样，推荐很奇怪。这里有些歧义，推荐有“让用户用的意思”，如果不符合用户的需求，也“推荐” 的话就不合适了。

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

wjhuang2016 · 2021-08-26T03:38:45Z

system-variables.md

+### `tidb_allow_function_for_expression_index` <span class="version-mark">从 v5.2.0 版本开始引入</span>
+
+- 作用域：NONE
+- 这个变量用于显示创建表达式索引所允许使用的函数。


同样，推荐很奇怪。这里有些歧义，推荐有“让用户用的意思”，如果不符合用户的需求，也“推荐” 的话就不合适了。

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn

LGTM

TomShawn · 2021-08-26T03:49:58Z

/merge

ti-chi-bot · 2021-08-26T03:49:59Z

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-08-26T03:51:30Z

/remove-status LGT1
/status LGT2

TomShawn · 2021-08-26T03:51:50Z

/merge

ti-chi-bot · 2021-08-26T03:51:53Z

This pull request has been accepted and is ready to merge.

Commit hash: 0504bf1

ti-chi-bot · 2021-08-26T03:52:40Z

In response to a cherrypick label: new pull request created: #6976.

1

6bbbcfa

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

ti-chi-bot requested a review from TomShawn August 25, 2021 08:38

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2021

TomShawn reviewed Aug 25, 2021

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn added needs-cherry-pick-release-5.2 translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. labels Aug 25, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 25, 2021

TomShawn added the type/enhancement The issue or PR belongs to an enhancement. label Aug 25, 2021

TomShawn assigned en-jin19 Aug 25, 2021

Update system-variables.md

1ed7423

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

bb7133 reviewed Aug 25, 2021

View reviewed changes

wjhuang2016 added 3 commits August 25, 2021 16:59

1

f88f2fa

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

Merge branch 'expridx' of github.com:wjhuang2016/docs-cn into expridx

aea1026

address comment

9e78ce8

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

TomShawn requested a review from bb7133 August 25, 2021 11:05

fix

e70b59e

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

bb7133 approved these changes Aug 25, 2021

View reviewed changes

TomShawn reviewed Aug 26, 2021

View reviewed changes

tidb-configuration-file.md Outdated Show resolved Hide resolved

TomShawn reviewed Aug 26, 2021

View reviewed changes

wjhuang2016 and others added 2 commits August 26, 2021 11:34

Update tidb-configuration-file.md

ee72724

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-statements/sql-statement-create-index.md

0b61958

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

wjhuang2016 commented Aug 26, 2021

View reviewed changes

Update sql-statements/sql-statement-create-index.md

0504bf1

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn approved these changes Aug 26, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2021

ti-chi-bot merged commit 95e9b95 into pingcap:master Aug 26, 2021

ti-chi-bot mentioned this pull request Aug 26, 2021

fix expression index's document again. (#6950) #6976

Merged

13 tasks

ti-chi-bot added a commit that referenced this pull request Aug 26, 2021

fix expression index's document again. (#6950) (#6976)

5e54a6a

en-jin19 mentioned this pull request Aug 26, 2021

docs: fix expression index's document again pingcap/docs#6295

Merged

12 tasks

en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 26, 2021

ti-chi-bot mentioned this pull request Aug 27, 2021

docs: fix expression index's document again (#6295) pingcap/docs#6309

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix expression index's document again. #6950

fix expression index's document again. #6950

wjhuang2016 commented Aug 25, 2021 •

edited

Loading

ti-chi-bot commented Aug 25, 2021 •

edited

Loading

bb7133 Aug 25, 2021

bb7133 Aug 25, 2021

ti-chi-bot commented Aug 25, 2021

wjhuang2016 Aug 26, 2021

wjhuang2016 Aug 26, 2021

TomShawn left a comment

TomShawn commented Aug 26, 2021

ti-chi-bot commented Aug 26, 2021

TomShawn commented Aug 26, 2021

TomShawn commented Aug 26, 2021

ti-chi-bot commented Aug 26, 2021

ti-chi-bot commented Aug 26, 2021

fix expression index's document again. #6950

fix expression index's document again. #6950

Conversation

wjhuang2016 commented Aug 25, 2021 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Aug 25, 2021 • edited Loading

bb7133 Aug 25, 2021

Choose a reason for hiding this comment

bb7133 Aug 25, 2021

Choose a reason for hiding this comment

ti-chi-bot commented Aug 25, 2021

wjhuang2016 Aug 26, 2021

Choose a reason for hiding this comment

wjhuang2016 Aug 26, 2021

Choose a reason for hiding this comment

TomShawn left a comment

Choose a reason for hiding this comment

TomShawn commented Aug 26, 2021

ti-chi-bot commented Aug 26, 2021

TomShawn commented Aug 26, 2021

TomShawn commented Aug 26, 2021

ti-chi-bot commented Aug 26, 2021

ti-chi-bot commented Aug 26, 2021

wjhuang2016 commented Aug 25, 2021 •

edited

Loading

ti-chi-bot commented Aug 25, 2021 •

edited

Loading