Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spm: add description for baseline capture filter #6948

Closed
wants to merge 2 commits into from
Closed

spm: add description for baseline capture filter #6948

wants to merge 2 commits into from

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Aug 25, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 25, 2021 08:22
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2021
@eurekaka eurekaka requested a review from Reminiscent August 25, 2021 08:22
@eurekaka eurekaka changed the title spm: add description for baseline capture spm: add description for baseline capture filter Aug 25, 2021
@TomShawn
Copy link
Contributor

@eurekaka Is it v5.2 affected? If yes, please add the v5.2 label. Thanks!

@TomShawn TomShawn added needs-cherry-pick-release-5.2 status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed missing-translation-status This PR does not have translation status info. labels Aug 30, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Sep 1, 2021

5.2 is not affected.

@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. labels Sep 6, 2021
@TomShawn TomShawn self-assigned this Sep 10, 2021
@ti-chi-bot
Copy link
Member

@Reminiscent: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ran-huang ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2022
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-release-6.0

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 14, 2022
@TomShawn TomShawn removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-cherry-pick-release-6.0 labels Apr 14, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2022
@lilin90 lilin90 removed the request for review from TomShawn April 3, 2023 08:41
@lilin90 lilin90 requested a review from ran-huang April 3, 2023 08:41
@lilin90 lilin90 assigned ran-huang and unassigned TomShawn Apr 3, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 26, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 26, 2023
@ran-huang
Copy link
Contributor

Closing this pull request because the content has been duplicated in another section.

@ran-huang ran-huang closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@ran-huang ran-huang Awaiting requested review from ran-huang

Assignees

@ran-huang ran-huang

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-future-release This PR only applies to master for now and might cherry-pick to a future release. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eurekaka @ti-chi-bot @TomShawn @ran-huang @Reminiscent