Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add referential_constraints under "information-schema" #6848

Merged
merged 3 commits into from
Sep 6, 2021
Merged

add referential_constraints under "information-schema" #6848

merged 3 commits into from
Sep 6, 2021

Conversation

en-jin19
Copy link
Contributor

What is changed, added or deleted? (Required)

added a document referential_constraints under "information-schema"

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 12, 2021
@en-jin19 en-jin19 requested a review from TomShawn August 12, 2021 07:51
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2021
@TomShawn
Copy link
Contributor

https://github.com/pingcap/docs/pull/6139/files#diff-af901fcf2c80c7a2e8e277df009f5454dbdd631c9298f1cfd46d9197c3baaefdR35 这一行未对齐。

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Aug 31, 2021
@en-jin19 @TomShawn
Apply suggestions from code review
b72d95d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Sep 2, 2021 •
edited
Loading

@en-jin19 This comment is not addressed?

https://github.com/pingcap/docs/pull/6139/files#diff-af901fcf2c80c7a2e8e277df009f5454dbdd631c9298f1cfd46d9197c3baaefdR35 这一行未对齐。

@en-jin19
Copy link
Contributor Author

en-jin19 commented Sep 2, 2021

@en-jin19 Have you missed this comment?

https://github.com/pingcap/docs/pull/6139/files#diff-af901fcf2c80c7a2e8e277df009f5454dbdd631c9298f1cfd46d9197c3baaefdR35 这一行未对齐。

Sorry, I missed it indeed. I have added it just now, please kindly take a look.

TomShawn
TomShawn approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2021
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Sep 2, 2021
@TomShawn TomShawn requested review from lilyjazz and removed request for lilyjazz September 2, 2021 07:41
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Sep 6, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1777faf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot ti-chi-bot merged commit 9ee971b into pingcap:master Sep 6, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 6, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7083.

ti-chi-bot added a commit that referenced this pull request Sep 6, 2021
@ti-chi-bot
add referential_constraints under "information-schema" (#6848) (#7083)
362b37f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@en-jin19 @ti-chi-bot @TomShawn