Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: add compatibility notes for sort-dir (#6648) (#6681) #6740

Closed
wants to merge 2 commits into from
Closed

cdc: add compatibility notes for sort-dir (#6648) (#6681) #6740

wants to merge 2 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6681

This is an automated cherry-pick of #6648

What is changed, added or deleted? (Required)

  • Added compatibility notes for sort-dir and data-dir in TiCDC

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
This is an automated cherry-pick of pingcap#6681
c709915 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. type/enhancement The issue or PR belongs to an enhancement. labels Jul 27, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 27, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot self-assigned this Jul 27, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 27, 2021 13:05
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2021
TomShawn
TomShawn reviewed Jul 27, 2021
View reviewed changes
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 27, 2021
View reviewed changes
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 27, 2021
View reviewed changes
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d3d3550

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2021
@TomShawn TomShawn removed requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Jul 28, 2021
@TomShawn TomShawn removed type/cherry-pick-for-master This PR is cherry-picked to master from a source PR. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Jul 28, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. missing-translation-status This PR does not have translation status info. status/can-merge Indicates a PR has been approved by a committer. labels Jul 28, 2021
@TomShawn TomShawn removed missing-translation-status This PR does not have translation status info. status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement. labels Jul 28, 2021
@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jul 28, 2021
@TomShawn TomShawn closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees

@ti-chi-bot ti-chi-bot

Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @CLAassistant @TomShawn