Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

best-practices: add timeout options for Java best practices #6710

Merged
merged 3 commits into from
Jul 22, 2021
Merged

best-practices: add timeout options for Java best practices #6710

merged 3 commits into from
Jul 22, 2021

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jul 21, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@jackysp
best-practices: add timeout options for Java best practices
0ae2107 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 21, 2021 07:15
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2021
@jackysp jackysp requested a review from lysu July 21, 2021 07:17
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2021
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2021
TomShawn
TomShawn reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments~

best-practices/java-app-best-practices.md Outdated Show resolved Hide resolved
best-practices/java-app-best-practices.md Outdated Show resolved Hide resolved
jackysp and others added 2 commits July 22, 2021 10:13
@jackysp @TomShawn
Update best-practices/java-app-best-practices.md
6dcbdca 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@jackysp @TomShawn
Update best-practices/java-app-best-practices.md
0ed7bd9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@jackysp
Copy link
Member Author

jackysp commented Jul 22, 2021

minor comments~

Done. Thanks!

TomShawn
TomShawn approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0ed7bd9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2021
@ti-chi-bot ti-chi-bot merged commit d84232d into master Jul 22, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@jackysp @3AceShowHand
best-practices: add timeout options for Java best practices (pingcap#…
6c2ed4b 
…6710)
@en-jin19 en-jin19 mentioned this pull request Aug 10, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2021
@TomShawn TomShawn deleted the add_timeout branch August 11, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@lysu lysu lysu approved these changes

Assignees

@en-jin19 en-jin19

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackysp @ti-chi-bot @TomShawn @lysu @en-jin19