Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs related to partition table dynamic mode #6542

Merged
merged 7 commits into from
Jul 5, 2021
Merged

update docs related to partition table dynamic mode #6542

merged 7 commits into from
Jul 5, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 28, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 28, 2021 06:21
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2021
@qw4990 qw4990 requested review from qiancai, tiancaiamao, lysu and rebelice and removed request for TomShawn June 28, 2021 06:22
@TomShawn TomShawn added needs-cherry-pick-release-5.1 translation/doing This PR’s assignee is translating this PR. labels Jun 28, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 28, 2021
qiancai
qiancai reviewed Jun 28, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@qw4990 @qiancai
Update system-variables.md
bd3787d 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 29, 2021 •
edited
Loading

@qw4990 Please resolve the conflicts
@lysu @rebelice @tiancaiamao PTAL

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2021
@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot
Copy link
Member

@tiancaiamao: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 5, 2021

All conflicts are resolved, PTAL @TomShawn @tiancaiamao

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 83c73bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ti-chi-bot ti-chi-bot merged commit a5a8ec8 into pingcap:master Jul 5, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 5, 2021
@qw4990 @ti-chi-bot
update docs related to partition table dynamic mode (pingcap#6542)
de733fe
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6614.

@TomShawn TomShawn assigned Liuxiaozhen12 and unassigned Joyinqin Jul 5, 2021
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
update docs related to partition table dynamic mode (#6542) (#6614)
1ca2c82
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 19, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@qw4990 @3AceShowHand
update docs related to partition table dynamic mode (pingcap#6542)
bcdb4a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@qiancai qiancai qiancai approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@rebelice rebelice Awaiting requested review from rebelice

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qw4990 @TomShawn @ti-chi-bot @tiancaiamao @lysu @qiancai @Joyinqin @Liuxiaozhen12