Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update complex-tiflash.yaml #3927

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Update complex-tiflash.yaml #3927

merged 3 commits into from
Jul 13, 2020

Conversation

flowbehappy
Copy link
Contributor

Add profiles.default.max_memory_usage and profiles.default.max_memory_usage_for_all_queries settings

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@flowbehappy flowbehappy requested a review from zanmato1984 July 9, 2020 04:26
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 9, 2020
zanmato1984
zanmato1984 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@zanmato1984, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 9, 2020
@flowbehappy flowbehappy mentioned this pull request Jul 9, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

@zanmato1984, @TomShawn, @kissmydb, @superlzs0476, PTAL.

zanmato1984
zanmato1984 approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@zanmato1984, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@flowbehappy @TomShawn
Update config-templates/complex-tiflash.yaml
bac58eb 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. labels Jul 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 0c2088c into master Jul 13, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
@flowbehappy @ti-srebot
cherry pick pingcap#3927 to release-4.0
3c001af 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3956

ti-srebot added a commit that referenced this pull request Jul 13, 2020
@ti-srebot @flowbehappy
Update complex-tiflash.yaml (#3927) (#3956)
3f0750f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Flowyi <flowbehappy@gmail.com>
@lilin90 lilin90 deleted the flowbehappy-patch-4 branch August 5, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@kissmydb kissmydb Awaiting requested review from kissmydb

@superlzs0476 superlzs0476 Awaiting requested review from superlzs0476

Assignees

@flowbehappy flowbehappy

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flowbehappy @ti-srebot @zanmato1984 @TomShawn