Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an "experimental feature" note in dashboard-intro.md #3675

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Add an "experimental feature" note in dashboard-intro.md #3675

merged 2 commits into from
Jun 19, 2020

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 16, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions bot requested a review from TomShawn June 16, 2020 05:45
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 16, 2020
@yikeke yikeke requested review from breezewish and jackysp June 16, 2020 05:45
@yikeke yikeke added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 16, 2020
TomShawn
TomShawn approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor Author

yikeke commented Jun 16, 2020

PTAL @breeswish

@yikeke yikeke mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

@TomShawn, @breeswish, @jackysp, PTAL.

breezewish
breezewish approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor Author

yikeke commented Jun 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6ed2ec9 into master Jun 19, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 19, 2020
@yikeke @ti-srebot
cherry pick pingcap#3675 to release-4.0
ce21441 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 19, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3722

ti-srebot added a commit that referenced this pull request Jun 19, 2020
@ti-srebot @yikeke
Add an "experimental feature" note in dashboard-intro.md (#3675) (#3722)
f7510c1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@breezewish breezewish deleted the yikeke-patch-1 branch June 19, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@breezewish breezewish breezewish approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yikeke @ti-srebot @breezewish @jackysp @TomShawn