Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: some minor update #3655

Merged
merged 4 commits into from
Jun 17, 2020
Merged

tools: some minor update #3655

merged 4 commits into from
Jun 17, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jun 15, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

  1. add get started for tidb-binlog
  2. move some content about loader to loader-overview.md

Aliases added in #3655.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@WangXiangUSTC WangXiangUSTC mentioned this pull request Jun 15, 2020
Merged
2 tasks
@WangXiangUSTC WangXiangUSTC requested a review from july2993 June 15, 2020 09:13
@TomShawn TomShawn self-assigned this Jun 15, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 15, 2020
july2993
july2993 reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 2e2badd into pingcap:master Jun 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 17, 2020
@WangXiangUSTC @ti-srebot
cherry pick pingcap#3655 to release-4.0
3d2b417 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3698

TomShawn pushed a commit that referenced this pull request Jun 17, 2020
@ti-srebot @WangXiangUSTC
cherry pick #3655 to release-4.0 (#3698)
66fce14 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: WangXiangUSTC <wx347249478@gmail.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@TomShawn TomShawn mentioned this pull request Jul 7, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 7, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 14, 2020
@TomShawn TomShawn removed their assignment Jul 14, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/no-need No need to translate this PR. labels Jul 14, 2020
@TomShawn TomShawn self-assigned this Jul 14, 2020
@TomShawn TomShawn mentioned this pull request Jul 14, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2020
Merged
5 tasks
@TomShawn TomShawn mentioned this pull request Aug 5, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @ti-srebot @july2993 @TomShawn @yikeke