Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add aliases for all 377 files in master branch #3094

Merged
merged 2 commits into from
May 14, 2020
Merged

*: add aliases for all 377 files in master branch #3094

merged 2 commits into from
May 14, 2020

Conversation

zhouqiang-cl
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl commented May 13, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke requested review from yikeke, lilin90 and YiniXu9506 May 13, 2020 15:40
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove .md from newly added aliases.

alert-rules.md Outdated
@@ -2,6 +2,7 @@
title: TiDB 集群报警规则
summary: TiDB 集群中各组件的报警规则详解。
category: reference
aliases: ['/docs-cn/dev/reference/alert-rules.md']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aliases: ['/docs-cn/dev/reference/alert-rules.md']
aliases: ['/docs-cn/dev/reference/alert-rules/']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 22618eb

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit abd9167 into pingcap:master May 14, 2020
@yikeke yikeke changed the title add alias *: add aliases for all 377 files in master branch May 14, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
* add alias

* fix aliases in all 377 files

Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants