-
Notifications
You must be signed in to change notification settings - Fork 1.2k
tikv: update rocksdb.max-manifest-file-size default value #20846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: glorv <glorvs@163.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hbisheng PTAL |
@@ -1255,7 +1255,7 @@ RocksDB 相关的配置项。 | |||
### `max-manifest-file-size` | |||
|
|||
+ RocksDB Manifest 文件最大大小。 | |||
+ 默认值:128MiB | |||
+ 默认值:256MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ 默认值:256MiB | |
+ 默认值:256MiB。在 v9.0.0 之前,默认值为 `128MiB`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
抱歉,这个也需要 cp 到老版本,上面忘记勾选相关的版本了。现在 cherry-pick 的流程有点复杂,不知道 cp 的 PR 啥时候才能 merge,所以本来是打算等相关 cp pr merge 了在更新 doc 的 pr 的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Connor1996: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
rocksdb.max-manifest-file-size
from 128MiB to 256MiB tikv/tikv#18496Do your changes match any of the following descriptions?