Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: configs of max-ts checker #19380

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Dec 25, 2024

What is changed, added or deleted? (Required)

Doc of 3 TiKV config items, introduced in tikv/tikv#17917

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

tikv/tikv#17916
tikv/tikv#17917

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium requested review from cfzjywxk and you06 December 25, 2024 03:17
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 25, 2024
### `max-ts-drift-allowance`

+ 读写请求更新 max-ts 时允许超过 TiKV 缓存的 PD TSO 的最大值。
+ 如果尝试更新的 max-ts 超过 TiKV 缓存的 PD TSO + allowance,认为该请求的来源不合法,会执行 [`action-on-invalid-max-ts`](#action-on-invalid-max-ts) 规定的行为。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充了一句

Signed-off-by: ekexium <eke@fastmail.com>
@lilin90 lilin90 added the v9.0 label Dec 26, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 26, 2024
@cfzjywxk cfzjywxk requested a review from joey-yez December 27, 2024 08:35
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jan 7, 2025
@hfxsd hfxsd requested a review from qiancai January 7, 2025 06:28
Signed-off-by: ekexium <eke@fastmail.com>
Copy link

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -561,6 +561,29 @@ I/O rate limiter 相关的配置项。
+ 可选值:`"read-only"`,`"write-only"`,`"all-io"`
+ 默认值:`"write-only"`

## `storage.max-ts`

### `max-drift`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `max-drift`
### `max-drift` <span class="version-mark">从 v9.0.0 版本开始引入</span>

+ 默认值:60s
+ 建议设置为[`cache-sync-interval`](#cache-sync-interval)的 3 倍以上。

### `cache-sync-interval`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `cache-sync-interval`
### `cache-sync-interval` <span class="version-mark">从 v9.0.0 版本开始引入</span>

+ TiKV 更新 PD TSO 缓存的时间间隔。该缓存用于检查 max-ts 更新的合法性。
+ 默认值:15s

### `action-on-invalid-update`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `action-on-invalid-update`
### `action-on-invalid-update` <span class="version-mark">从 v9.0.0 版本开始引入</span>

+ `"error"`:TiKV 会将错误返回。
+ `"log"`:TiKV 会打印 error 日志并继续执行。
+ 默认值:`"panic"`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般情况下,这 3 个配置项请按字母顺序排列

action-on-invalid-update
cache-sync-interval
max-drift

@@ -561,6 +561,29 @@ I/O rate limiter 相关的配置项。
+ 可选值:`"read-only"`,`"write-only"`,`"all-io"`
+ 默认值:`"write-only"`

## `storage.max-ts`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要加一句话介绍这个配置项组的作用


### `max-drift`

+ 读写请求更新 max-ts 时允许超过 TiKV 缓存的 PD TSO 的最大值。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搜了下,文档里其他地方都没有介绍过 max-ts 是什么,因此这里需要介绍下,或者用中文含义代替

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants