-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gcs:// instead of s3:// when the external storage is Google Cloud Storage #16937
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sdojjy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -51,6 +51,10 @@ tiup cdc:v7.5.0 cli changefeed create \ | |||
```shell | |||
s3://external/test.csv?access-key=${access-key}&secret-access-key=${secret-access-key} | |||
``` | |||
> **注意:** | |||
> | |||
> 请注意,GCS 的 XML API 没有完全兼容 `s3://` 协议, 如果你使用的是 GCS,请使用 `gcs://` 协议。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还是推荐 PM 检查 gcs:// 是否能完全覆盖 s3:// 的场景,用户当初想使用 s3://,现在我们想让他改成 gcs:// 会不会遇到什么困难
First-time contributors' checklist
What is changed, added or deleted? (Required)
here is https://github.com/pingcap/docs/pull/16893/files
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?