Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: add the user's guide of stale read and safe ts #15365

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Nov 3, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Add the description of tikv-ctl subcommand get-region-read-progress
  • Add a guide to diagnose issues related to stale read and safe-ts.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 3, 2023
@Oreoxmt Oreoxmt added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 labels Nov 3, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 3, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Nov 3, 2023

/cc @ekexium @hfxsd

@ti-chi-bot ti-chi-bot bot requested review from ekexium and hfxsd November 3, 2023 01:42
grafana-tidb-dashboard.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to Oreoxmt/pingcap-docs-website-scaffold that referenced this pull request Nov 3, 2023
- Resolved-TS worker CPU:resolved-ts worker 线程的 CPU 使用率
- Advance-TS worker CPU:advance-ts worker 线程的 CPU 使用率
- Scan lock worker CPU:scan lock worker 线程的 CPU 使用率
- Max gap of resolved-ts:在当前 TiKV 中,所有活跃 Region 的 resolved-ts 与当前时间的最大差值
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

截图上的名称是 Max Resolved TS gap

Suggested change
- Max gap of resolved-ts:在当前 TiKV 中,所有活跃 Region 的 resolved-ts 与当前时间的最大差值
- Max Resolved TS gap:在当前 TiKV 中,所有活跃 Region 的 resolved-ts 与当前时间的最大差值

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekexium PTAL and update the English document if necessary.

Copy link
Member

@ekexium ekexium Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In older version it's "Max Resolved TS gap". It's been renamed to "Max gap of resolved-ts". The pic is captured from an older version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this pic? media/stale-read/example-ts-gap.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary. We can comment the rename here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

troubleshoot-stale-read.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Copy link
Member

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文的我也对应改了一下

grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
troubleshoot-stale-read.md Outdated Show resolved Hide resolved
Co-authored-by: ekexium <eke@fastmail.com>
Copy link

ti-chi-bot bot commented Nov 6, 2023

@ekexium: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt requested a review from hfxsd November 6, 2023 06:11
Copy link

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 01:26:51.673793979 +0000 UTC m=+3694009.260904124: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 9, 2023
@Oreoxmt Oreoxmt added the lgtm label Nov 9, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Nov 9, 2023

/approve

Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit bf686f1 into pingcap:master Nov 9, 2023
3 of 4 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15408.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 9, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15409.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 9, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15410.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants