Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system variable: rename tidb_ddl_distribute_reorg to tidb_enable_dist_task #13549

Merged
merged 14 commits into from
Apr 25, 2023
Merged

system variable: rename tidb_ddl_distribute_reorg to tidb_enable_dist_task #13549

merged 14 commits into from
Apr 25, 2023

Conversation

Benjamin2037
Copy link
Contributor

@Benjamin2037 Benjamin2037 commented Mar 29, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

修改系统参数 tidb_ddl_distribute_reorg 为 tidb_enable_dist_task。

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from Oreoxmt March 29, 2023 09:03
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2023
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Mar 29, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 29, 2023
@Oreoxmt Oreoxmt added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v7.1 This PR/issue applies to TiDB v7.1. labels Mar 29, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang March 29, 2023 09:38
@Oreoxmt Oreoxmt changed the title 修改系统参数 system variable: rename tidb_ddl_distribute_reorg to tidb_enable_dist_task Mar 30, 2023
@Benjamin2037
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2023
ran-huang
ran-huang reviewed Apr 10, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Benjamin2037 and others added 5 commits April 12, 2023 13:32
@Benjamin2037 @ran-huang
Update system-variables.md
529653e 
Co-authored-by: Ran <huangran.alex@gmail.com>
@Benjamin2037 @ran-huang
Update system-variables.md
71e8ead 
Co-authored-by: Ran <huangran.alex@gmail.com>
@Benjamin2037 @ran-huang
Update system-variables.md
0eb0861 
Co-authored-by: Ran <huangran.alex@gmail.com>
@Benjamin2037
Add support scope.
2e93b8b
@Benjamin2037
Merge branch '7.0-change_system_variable' of github.com:pingcap/docs-…
a464ce8 
…cn into 7.0-change_system_variable
@Oreoxmt Oreoxmt removed their request for review April 14, 2023 02:43
ran-huang
ran-huang reviewed Apr 17, 2023
View reviewed changes
system-variables.md Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2023
@ran-huang ran-huang requested a review from zimulala April 18, 2023 03:52
zimulala
zimulala reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2023
@ran-huang ran-huang requested a review from qiancai April 19, 2023 05:57
@ran-huang ran-huang mentioned this pull request Apr 19, 2023
Merged
15 tasks
qiancai
qiancai reviewed Apr 19, 2023
View reviewed changes
releases/release-6.6.0.md Outdated Show resolved Hide resolved
releases/release-6.6.0.md Outdated Show resolved Hide resolved
releases/release-6.6.0.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ran-huang @qiancai
Apply suggestions from code review
75229a4 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 20, 2023
@ran-huang ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2023
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 75229a4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit d18183e into master Apr 25, 2023
@ran-huang ran-huang deleted the 7.0-change_system_variable branch April 25, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@ran-huang ran-huang ran-huang approved these changes

@zimulala zimulala zimulala approved these changes

Assignees

@ran-huang ran-huang

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjamin2037 @ti-chi-bot @ran-huang @zimulala @qiancai @Oreoxmt