Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-faq: add missing DELAYED priority #13523

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 24, 2023

What is changed, added or deleted? (Required)

Add the missing DELAYED priority

sql> SELECT HIGH_PRIORITY 1;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.0014 sec)

sql> SELECT LOW_PRIORITY 1;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.0004 sec)

sql> SELECT DELAYED 1;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.0004 sec)

see also: https://github.com/pingcap/tidb/blob/1e0956d5ba41182e603295e02ae8f767d62979e4/distsql/request_builder.go#L257-L267

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs This PR is translated from a PR in pingcap/docs. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 24, 2023
@Oreoxmt Oreoxmt requested a review from tiancaiamao March 24, 2023 07:01
@Oreoxmt Oreoxmt self-assigned this Mar 24, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 24, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2023
@Oreoxmt Oreoxmt requested a review from qiancai April 4, 2023 08:18
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 6, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88e46cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2023
@ti-chi-bot ti-chi-bot merged commit 2bf0a92 into pingcap:master Apr 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13606.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13607.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13608.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #13609.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13610.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 6, 2023
@Oreoxmt Oreoxmt deleted the translate/docs-12237 branch October 20, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants