sql: fix some format mistakes #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzabelWang
changed the title
lilin90
reviewed
Apr 24, 2019
sql/slow-query.md
Outdated
| | select * from t1 where a>2; | 0.602011247 | t1:pseudo | | ||
| | select * from t1 where a>3; | 0.50077719 | t1:pseudo | | ||
| | select * from t1 join t2; | 0.931260518 | t1:407872303825682445,t2:pseudo | | ||
| | select * from t1 where a=1; | 0.302558006 | t1: pseudo | |
There was a problem hiding this comment.
These spaces in this code block might be unnecessary. Please check with @crazycs520.
There was a problem hiding this comment.
Yes, It is the result of the sql query. These spaces in this code block is unnecessary
There was a problem hiding this comment.
@IzabelWang So please change it back.
There was a problem hiding this comment.
OK, done~
PTAL @lilin90
bb7133
reviewed
Apr 24, 2019
Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com>
Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com>
Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com>
Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com>
Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com>
lilin90
reviewed
Apr 25, 2019
sql/slow-query.md
Outdated
| @@ -161,13 +161,13 @@ tidb > select query, query_time, stats from INFORMATION_SCHEMA.`SLOW_QUERY` wher | |||
| | select * from t1 where a=2; | 0.401313532 | t1:pseudo | | |||
| | select * from t1 where a>2; | 0.602011247 | t1:pseudo | | |||
| | select * from t1 where a>3; | 0.50077719 | t1:pseudo | | |||
| | select * from t1 join t2; | 0.931260518 | t1:407872303825682445,t2:pseudo | | |||
| | select * from t1 join t2; | 0.931260518 | t1:407872303825682445,t2: pseudo | | |||
There was a problem hiding this comment.
Why leave one space for this line?
There was a problem hiding this comment.
Sorry & addressed~
lilin90
added a commit
that referenced
this pull request
May 13, 2019
* sql: update tidb slow log operation * update log * update log * modify the translation: requirements vs recommendations * improve the translation * dm: add description for task overview monitor * dm: add description for instances' monitor * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * dm: address comments * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * v2.1/tools, v2.1/tools: update TiDB-Binlog (#1245) v2.1/tools: update TiDB-Binlog * fix incorrect IP address parsing and other inline code formatting * *: move overview and features (#1253) Via: pingcap/docs#1045 * TOC: update the quickstart link (#1255) * sql: remove redundant content in privilege && user, tiny clean up * Apply suggestions from code review Co-Authored-By: dcalvin <wenghao@pingcap.com> * Apply suggestions from code review Co-Authored-By: dcalvin <wenghao@pingcap.com> * Update tools/dm/monitor.md Co-Authored-By: csuzhangxc <csuzhangxc@gmail.com> * dm: address comments * add digest declare * update eg * add stats eg * update eg * address comment and add more field * TOC: covert docs-cn to DITA TOC (#1242) * TOC: covert docs-cn to DITA TOC * TOC: update wording * TOC: refine wording * toc: update description and a link * toc: update wording * toc: update a file name * toc: remove the K8s link * toc: fix a link about incremental replication * toc: update a blog post link to Chinese version * toc: fix a link and update wording * toc: update key features and overview * toc: update About TiDB * add declare for v2.1.8 * address comment * change the link of back-restore in tidb-binlog document * address comment * *: remove doc redundant space * sql/slow_query: add pt-digest-query version * tools: update a lightning download link * address comment * sql, TOC: update doc title (#1262) * benchmark: update the Note format * op-guide: update the Note format * benchmark, op-guide: Update the Note format (#1273) benchmark, op-guide: update the Note format * *: update the Note format * address comment * *: update the Note format * benchmark, v2.1/benchmark: remove an invalid link (#1275) * benchmark: remove an invalid link * v2.1/benchmark: remove an invalid link * update condition (#1265) * Update sql/slow-query.md Co-Authored-By: crazycs520 <crazycs520@gmail.com> * Update sql/slow-query.md Co-Authored-By: crazycs520 <crazycs520@gmail.com> * sql: update the USE command explanation in util document (#1269) * docs-cn #1112 Update the USE command explanation in util document * Update sql/util.md LGTM Co-Authored-By: ericsyh <ericshenyuhao@outlook.com> * Update v1.0/sql/util.md LGTM Co-Authored-By: ericsyh <ericshenyuhao@outlook.com> * Update v2.0/sql/util.md LGTM Co-Authored-By: ericsyh <ericshenyuhao@outlook.com> * Update v2.1/sql/util.md LGTM Co-Authored-By: ericsyh <ericshenyuhao@outlook.com> * update the loader pprof-addr default port (#1256) * tools: clarify meaning of "N/A" (#1267) * releases: correct the TiDB-Ansible version (#1280) * sql: fix some format mistakes (#1277) * Sql: fix some format mistakes * Update sql/slow-query.md Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com> * Update sql/slow-query.md Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com> * Update sql/slow-query.md Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com> * Update op-guide/tidb-config-file.md Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com> * Update sql/slow-query.md Co-Authored-By: IzabelWang <37297881+IzabelWang@users.noreply.github.com> * Remove unnecessary space * Update slow-query.md * Update slow-query.md * sql: update generated columns docs * address comment and add issue link * *: rename how-to get started (#1281) * *: rename how-to get started Related PR: pingcap/docs#1046 * *: fix aliases link path * sql: update content structure and wording (#1259) * TOC: update a doc title (#1285) * tools/lightning: fix a broken link (#1287) * explain for update statement (#1284) * tools, toc: reorganize TiDB Binlog documents (#1264) * reorg the binlog documents * update TOC format * change the pd to file in overview * update the ansible-deployment link * rename the previous version of tidb-binlog to tidb-binlog-local * Make the explaination of pausing and paused more clear * change the order in TOC * uncomment some necessary configs in kafka version * add more explaination of paused and offline in overview * fix the typo * Add the Topic config in Kafka driver * update the gc intro in deployment * remove unnecessary step in deployment * remove the compression in deploy document * remove sql in the file dainer * update the download link in deployment * Time and size limits delete * abandon enable-tolerant config * move the reparo document into binlog folder * update the rapero download link * update drainer_pd to drainer_file * trouble-shooting: update the issue report link (#1289) * trouble-shooting: update the issue report link * Update trouble-shooting.md Co-Authored-By: CaitinChen <34535727+CaitinChen@users.noreply.github.com> * Update trouble-shooting.md Co-Authored-By: CaitinChen <34535727+CaitinChen@users.noreply.github.com> * Update trouble-shooting.md Co-Authored-By: CaitinChen <34535727+CaitinChen@users.noreply.github.com> * tools/binlog: optimize the TiDB-Binlog documents (#1291) * fix some problems with suggestions from Lilian and Calvin * tools/binlog: fix and update format (#1292) * tools/binlog: fix and update format * tools/binlog: update wording * tools/binlog: update a link * Update tools/binlog/upgrade.md Co-Authored-By: lilin90 <lilin@pingcap.com> * tools: update syncer batch size (#1288) * tools/dm: fix the error in valus from ansible command (#1293) * sql: fix punctuation and format * circle.yml: [WIP] comment publish pdf cmd * TOC, releases: add 2.1.9 release notes (#1298) * TOC, releases: add 2.1.9 release notes PTAL * Update 2.1.9.md * releases: fix format * tools: update loader status addr (#1299) * Add charset check in Syncer precheck (#1300) * Add charset check in Syncer precheck * Update tools/syncer.md Co-Authored-By: ericsyh <ericshenyuhao@outlook.com> * circle.yml: remove IP address (#1301) * *: change "登陆" to “登录” (#1302) * sql: fix format (#1303) * sql: update a comma (#1305) * sql: replace "jeffrey" with "test" (#1309) * op-guide/monitor: update the PD API DOC link (#1311) * Update the link * Update the PD API DOC link * tools: fix the format error in Syncer (#1306) * Fix the format error in Syncer * Update tools/syncer.md Co-Authored-By: ericsyh <ericshenyuhao@outlook.com> * update a link (#1313) * op-guide: add a guide about upgrading to 3.0 (#1258) * Add rolling update TiDB 3.0 guide. * Add rolling update TiDB 3.0 guide. * Apply suggestions from code review Co-Authored-By: superlzs0476 <43946384+superlzs0476@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review Co-Authored-By: liubo <liubo@pingcap.com> * op-guide: update a note format * op-guide: update wording * op-guide: update format * circle.yml: add a new IP for qiniu (#1315) * sql: fix typo (#1286) * media, tools: update TiDB-Lightning architecture Via: pingcap/docs#1128 * Delete useless instruction (#1308) * TOC, releases: add TiDB 3.0.0 RC1 release notes (#1316) * TOC, releases: add TiDB 3.0.0 RC1 release notes PTAL * Fix format * add new updates * Update TOC.md * Update rn.md * op-guide, toc: fix upgrade wording and update TOC (#1318) * op-guide, tools: fix a link and remove duplicated file (#1319) * *: update version limit for DM/Syncer (#1312) * toc, support: reorganize TOC and update a link (#1320) * toc, support: reorganize TOC and update a link Related PR: #1279 * toc: udpate description * toc: update wording * *: rename how-to deploy/configure/secure/monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some format mistakes in op-guide\tidb-config-file.md and sql\slow-query.md.
PTAL @lilin90 @bb7133