Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add annotation for localization #12161

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Nov 30, 2022

What is changed, added or deleted? (Required)

A complement to #12153

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang added area/general Relates to TiDB overview, architecture, and other general descriptions. require-LGT1 Indicates that the PR requires an LGTM. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 labels Nov 30, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 30, 2022 07:42
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2022
@ran-huang ran-huang added the translation/no-need No need to translate this PR. label Nov 30, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 30, 2022
ran-huang and others added 2 commits November 30, 2022 15:57
Signed-off-by: Ran <huangran.alex@gmail.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2022
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d9d888f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@ti-chi-bot ti-chi-bot merged commit 77e2eaa into pingcap:master Dec 1, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12170.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 1, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ran-huang ran-huang deleted the add-annotation-l10n branch December 1, 2022 03:57
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general Relates to TiDB overview, architecture, and other general descriptions. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants