Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: update headings #11987

Merged
merged 5 commits into from
Nov 16, 2022
Merged

dm: update headings #11987

merged 5 commits into from
Nov 16, 2022

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

as title.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs This PR is translated from a PR in pingcap/docs. require-LGT1 Indicates that the PR requires an LGTM. area/dm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Nov 14, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2022
shichun-0415
shichun-0415 reviewed Nov 14, 2022
View reviewed changes
dm/dm-create-task.md Outdated Show resolved Hide resolved
dm/dm-error-handling.md Outdated Show resolved Hide resolved
dm/dm-export-import-config.md Outdated Show resolved Hide resolved
dm/dm-export-import-config.md Outdated Show resolved Hide resolved
dm/dm-generate-self-signed-certificates.md Outdated Show resolved Hide resolved
dm/quick-start-create-source.md Outdated
@@ -1,9 +1,9 @@
---
title: 创建数据源
title: 创建 DM 数据源
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 创建 DM 数据源
title: 创建 TiDB Data Migration 数据源

dm/quick-start-create-source.md Outdated
summary: 了解如何为 DM 创建数据源。
---

# 创建数据源
# 创建 DM 数据源
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 创建 DM 数据源
# 创建 TiDB Data Migration 数据源

dm/quick-start-create-task.md Outdated
@@ -1,10 +1,10 @@
---
title: 创建数据迁移任务
title: 创建 DM 数据迁移任务
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 创建 DM 数据迁移任务
title: 创建 TiDB Data Migration 数据迁移任务

dm/quick-start-create-task.md Outdated
summary: 了解在部署 DM 集群后，如何快速创建数据迁移任务。
aliases: ['/docs-cn/tidb-data-migration/dev/quick-start-create-task/']
---

# 创建数据迁移任务
# 创建 DM 数据迁移任务
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 创建 DM 数据迁移任务
# 创建 TiDB Data Migration 数据迁移任务

dm/quick-start-create-task.md Outdated
summary: 了解在部署 DM 集群后，如何快速创建数据迁移任务。
aliases: ['/docs-cn/tidb-data-migration/dev/quick-start-create-task/']
---

# 创建数据迁移任务
# 创建 DM 数据迁移任务

本文档介绍在 DM 集群部署成功后，如何快速创建简单的数据迁移任务。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
本文档介绍在 DM 集群部署成功后，如何快速创建简单的数据迁移任务。
本文档介绍在 TiDB Data Migration (DM) 集群部署成功后，如何快速创建简单的数据迁移任务。

ran-huang and others added 2 commits November 15, 2022 15:42
@ran-huang @shichun-0415
Apply suggestions from code review
273c7dd 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@ran-huang
address comments
933e1a6
shichun-0415
shichun-0415 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dm/dm-create-task.md Outdated
@@ -1,12 +1,12 @@
---
title: 创建数据迁移任务
title: 创建 DM 数据迁移任务
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉要么 创建 TiDB Data Migration 数据迁移任务，要么创建数据迁移任务

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2022
ran-huang
ran-huang commented Nov 16, 2022
View reviewed changes
dm/dm-create-task.md Outdated Show resolved Hide resolved
ran-huang
ran-huang commented Nov 16, 2022
View reviewed changes
dm/dm-create-task.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6c3afc5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2022
@ti-chi-bot ti-chi-bot merged commit b28caa4 into master Nov 16, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12017.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 16, 2022
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#11987
c3aaf58 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12018.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 16, 2022
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#11987
d55308c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12019.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 16, 2022
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#11987
41a5c6c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #12020.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 16, 2022
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#11987
daa7bf2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2022
Merged
10 tasks
@ran-huang ran-huang deleted the dm/update-headings branch November 16, 2022 09:09
ti-chi-bot added a commit that referenced this pull request Nov 16, 2022
@ti-chi-bot
dm: update headings (#11987) (#12020)
7b2f5ce
ti-chi-bot added a commit that referenced this pull request Nov 16, 2022
@ti-chi-bot
dm: update headings (#11987) (#12019)
342e44a
ti-chi-bot added a commit that referenced this pull request Nov 16, 2022
@ti-chi-bot
dm: update headings (#11987) (#12018)
3de4ac6
ti-chi-bot added a commit that referenced this pull request Nov 16, 2022
@ti-chi-bot
dm: update headings (#11987) (#12017)
ce9dc0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
area/dm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-chi-bot @shichun-0415