Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

When backing up an empty cluster, nothing will be output. #1016

Closed
tongtongyin opened this issue Apr 15, 2021 · 2 comments · Fixed by #1033
Closed

When backing up an empty cluster, nothing will be output. #1016

tongtongyin opened this issue Apr 15, 2021 · 2 comments · Fixed by #1033
Labels
type/bug Something isn't working

Comments

@tongtongyin
Copy link
Contributor

tongtongyin commented Apr 15, 2021

Please answer these questions before submitting your issue. Thanks!!

  1. What did you do?
    When backing up an empty cluster, nothing will be output.It will not show that the backup is complete, nor will it show an error.

  2. What did you expect to see?
    Similar to a summary :["Full backup Failed summary: total backup ranges: 0, total success: 0, total failed: 0"] [BackupTS=xxxxxxxxxxxxxxxxxx]

  3. What did you see instead?
    Nothing at all

  4. What version of BR and TiDB/TiKV/PD are you using?

  1. Operation logs
    command:

command

brlog:
log

  1. Configuration of the cluster and the task

    • tidb-lightning.toml for TiDB-Lightning if possible
    • tikv-importer.toml for TiKV-Importer if possible
    • topology.yml if deployed by TiUP
  2. Screenshot/exported-PDF of Grafana dashboard or metrics' graph in Prometheus if possible

@tongtongyin tongtongyin added the type/bug Something isn't working label Apr 15, 2021
@tongtongyin tongtongyin reopened this Apr 15, 2021
@tongtongyin tongtongyin reopened this Apr 15, 2021
@kennytm
Copy link
Collaborator

kennytm commented Apr 15, 2021

please see #828 about backing up empty database.

@YuJuncen
Copy link
Collaborator

YuJuncen commented Apr 19, 2021

Uh, seems the failure summary was putted with log.Info, which record logs to the log file only.

br/pkg/summary/collector.go

Lines 187 to 191 in 31e539c

if len(tc.failureReasons) != 0 || !tc.successStatus {
for unitName, reason := range tc.failureReasons {
logFields = append(logFields, zap.String("unit-name", unitName), zap.Error(reason))
}
log.Info(name+" failed summary", logFields...)

Let me fix it... Thanks for reporting this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants